Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 580593002: Add TextureMailboxDeleter to cc::Display. (Closed)

Created:
6 years, 3 months ago by jbauman
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add TextureMailboxDeleter to cc::Display. BUG= Committed: https://crrev.com/e7002da73ea0a881bea02bab6781672ca3eeb7b4 Cr-Commit-Position: refs/heads/master@{#297289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M cc/surfaces/display.h View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/surfaces/display.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbauman
6 years, 3 months ago (2014-09-16 21:46:41 UTC) #2
jamesr
Hmm, as I understand it TextureMailboxDeleter is a utility for handling callbacks across different threads. ...
6 years, 3 months ago (2014-09-16 22:52:13 UTC) #3
jbauman
On 2014/09/16 22:52:13, jamesr wrote: > Hmm, as I understand it TextureMailboxDeleter is a utility ...
6 years, 3 months ago (2014-09-16 22:59:08 UTC) #4
jbauman
ping. Without this, a bunch of types of CopyOutputRequests DCHECK because they can't create a ...
6 years, 2 months ago (2014-09-25 22:32:31 UTC) #5
jamesr
lgtm This is unfortunately heavyweight for this use case, but we can optimize later.
6 years, 2 months ago (2014-09-29 21:53:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580593002/1
6 years, 2 months ago (2014-09-29 21:56:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as d696b75ec57aa15245f8dcfda1bf8b2736639a92
6 years, 2 months ago (2014-09-29 22:39:21 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 22:40:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7002da73ea0a881bea02bab6781672ca3eeb7b4
Cr-Commit-Position: refs/heads/master@{#297289}

Powered by Google App Engine
This is Rietveld 408576698