Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 580553002: Remove deprecated cursor event filter for Ozone (Closed)

Created:
6 years, 3 months ago by dnicoara
Modified:
6 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, ozone-reviews_chromium.org, ben+ash_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated cursor event filter for Ozone Removes the old filter in favor of the new one which is enabled by default on non-Ozone CrOS builds. BUG=none TESTS=ran ash_unittests --gtest_filter=MouseCursorEventFilterTest.* on an Ozone build and manually tested on link_freon Committed: https://crrev.com/cee48a5ba8c24eb8b8ea7f789e3025ac79549a4d Cr-Commit-Position: refs/heads/master@{#295169}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -206 lines) Patch
M ash/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/ash.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 6 chunks +0 lines, -6 lines 0 comments Download
D ash/display/mouse_cursor_event_filter_ozone.cc View 1 chunk +0 lines, -107 lines 0 comments Download
M ash/display/mouse_cursor_event_filter_unittest.cc View 2 chunks +0 lines, -79 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
dnicoara
PTAL
6 years, 3 months ago (2014-09-16 21:22:19 UTC) #2
oshima
lgtm++
6 years, 3 months ago (2014-09-16 21:40:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580553002/20001
6 years, 3 months ago (2014-09-16 22:02:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9f997f41ad01c30b6b637a6dffb650d89af88074
6 years, 3 months ago (2014-09-16 22:57:52 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/cee48a5ba8c24eb8b8ea7f789e3025ac79549a4d Cr-Commit-Position: refs/heads/master@{#295169}
6 years, 3 months ago (2014-09-16 22:59:06 UTC) #7
acolwell GONE FROM CHROMIUM
6 years, 3 months ago (2014-09-16 23:46:27 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/567413003/ by acolwell@chromium.org.

The reason for reverting is: This appears to be causing
ImmersiveFullscreenControllerTest.MouseEventsVerticalDisplayLayout to fail on
Chromium OS Ozone bots.
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2....

Powered by Google App Engine
This is Rietveld 408576698