Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 580473002: Remove obsolete FRIEND statements. (Closed)

Created:
6 years, 3 months ago by Bence
Modified:
6 years, 3 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete FRIEND statements. HttpNetworkTransactionSpdy*Test has been removed in https://crrev.com/17028007, making these FRIEND statements obsolete. BUG=118883 Committed: https://crrev.com/425a4c52cd3cd4539b70a9077ba27f2935c23da2 Cr-Commit-Position: refs/heads/master@{#295271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M net/base/upload_file_element_reader.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
PTAL. Thank you.
6 years, 3 months ago (2014-09-16 19:07:16 UTC) #2
mmenke
On 2014/09/16 19:07:16, Bence wrote: > PTAL. Thank you. LGTM
6 years, 3 months ago (2014-09-17 13:40:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/580473002/1
6 years, 3 months ago (2014-09-17 13:51:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as b0838b280beb36a2f39554cc512edbd2568be3e5
6 years, 3 months ago (2014-09-17 14:20:12 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 14:20:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/425a4c52cd3cd4539b70a9077ba27f2935c23da2
Cr-Commit-Position: refs/heads/master@{#295271}

Powered by Google App Engine
This is Rietveld 408576698