Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 580403004: Passworde bubble should close without fading out. (Closed)

Created:
6 years, 3 months ago by vasilii
Modified:
6 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Passworde bubble should close without fading out. This reverts https://codereview.chromium.org/520743002/ BUG=394287 Committed: https://crrev.com/faf5e8d6cdcf08e45c370b3a96a00172a6103377 Cr-Commit-Position: refs/heads/master@{#295725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -151 lines) Patch
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 3 chunks +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 8 chunks +2 lines, -65 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc View 6 chunks +4 lines, -64 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
vasilii
Hi Vaclav, please review.
6 years, 3 months ago (2014-09-19 12:45:22 UTC) #2
vabr (Chromium)
LGTM! Code-health-wise this is a great CL. I'm sorry to see your fine work on ...
6 years, 3 months ago (2014-09-19 13:08:49 UTC) #3
vasilii
On 2014/09/19 13:08:49, vabr (Chromium) wrote: > LGTM! > > Code-health-wise this is a great ...
6 years, 3 months ago (2014-09-19 13:15:07 UTC) #4
vabr (Chromium)
On 2014/09/19 13:15:07, vasilii wrote: > On 2014/09/19 13:08:49, vabr (Chromium) wrote: > > LGTM! ...
6 years, 3 months ago (2014-09-19 13:19:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580403004/1
6 years, 3 months ago (2014-09-19 13:26:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0ef138e15fa2de4f786db35e760d00854d437783
6 years, 3 months ago (2014-09-19 17:31:45 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 17:32:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/faf5e8d6cdcf08e45c370b3a96a00172a6103377
Cr-Commit-Position: refs/heads/master@{#295725}

Powered by Google App Engine
This is Rietveld 408576698