Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 580403003: Remove Gamepad runtime flag (status=stable) for chromium (Closed)

Created:
6 years, 3 months ago by heeyoun.lee
Modified:
6 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, eseidel, kangil_, tfarina, pdr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Gamepad runtime flag (status=stable) for chromium BUG=402536 Committed: https://crrev.com/231e285c50ae938b239db144975112dbe13e640d Cr-Commit-Position: refs/heads/master@{#296660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
heeyoun.lee
This is for chromium. PTAL blink : https://codereview.chromium.org/582363002/
6 years, 3 months ago (2014-09-19 08:57:24 UTC) #2
Avi (use Gerrit)
lgtm
6 years, 3 months ago (2014-09-20 01:09:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580403003/1
6 years, 3 months ago (2014-09-22 04:51:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580403003/1
6 years, 3 months ago (2014-09-25 05:55:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as aa50476305f74c67b850b0a5bbcfe1c3120cf9d3
6 years, 3 months ago (2014-09-25 05:55:51 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/231e285c50ae938b239db144975112dbe13e640d Cr-Commit-Position: refs/heads/master@{#296660}
6 years, 3 months ago (2014-09-25 05:56:29 UTC) #10
kbalazs
On 2014/09/25 05:56:29, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
6 years, 2 months ago (2014-10-07 18:30:46 UTC) #11
kbalazs
On 2014/10/07 18:30:46, kbalazs wrote: > On 2014/09/25 05:56:29, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-07 20:35:34 UTC) #12
kbalazs
6 years, 2 months ago (2014-10-07 20:48:36 UTC) #13
Message was sent while issue was closed.
On 2014/10/07 20:35:34, kbalazs wrote:
> On 2014/10/07 18:30:46, kbalazs wrote:
> > On 2014/09/25 05:56:29, I haz the power (commit-bot) wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/231e285c50ae938b239db144975112dbe13e640d
> > > Cr-Commit-Position: refs/heads/master@{#296660}
> > 
> > Hey guys, this will not work. I believe it will cause us to expose the
gamepad
> > api but it will not work, because it relies on 4.4 api's. So actually it
will
> > result in a crash (unexistent function java exception).
> 
> Revising my standpoint (and not). It won't crash, just doesn't work. But than
we
> should not expose the js api if the feature doesn't work.

Now I change my mind...

[16:42] <jamesr__> won't it just return an empty list of gamepads?
[16:43] <kbalazs> jamesr__: yes, I think it will do that. hm, maybe I'm too
paranoid.
[16:44] <jamesr__> sounds like working to me
[16:46] <kbalazs> jamesr__: ok, you buyed me. I was indeed too paranoic.

Sorry for the paranoia.

Powered by Google App Engine
This is Rietveld 408576698