Chromium Code Reviews
Help | Chromium Project | Sign in
(391)

Issue 5804003: Revert change 5989, which causes failures in some benchmarks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 7 months ago by William Hesse
Modified:
4 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Revert change 5989, which causes failures in some benchmarks. Committed: http://code.google.com/p/v8/source/detail?r=5991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -301 lines) Patch
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/code-stubs.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 4 chunks +2 lines, -39 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 2 chunks +0 lines, -19 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -131 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 5 chunks +32 lines, -64 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +16 lines, -22 lines 0 comments Download
M src/math.js View 1 chunk +0 lines, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
William Hesse
4 years, 7 months ago (2010-12-13 16:32:00 UTC) #1
Kevin Millikin (Chromium)
4 years, 7 months ago (2010-12-13 16:33:57 UTC) #2
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5