Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 580383003: Reland sticky regexps https://codereview.chromium.org/567313003/ (Closed)

Created:
4 years, 2 months ago by Erik Corry
Modified:
4 years, 2 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -54 lines) Patch
M src/bootstrapper.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M src/compilation-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/flag-definitions.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M src/objects.h View 2 chunks +8 lines, -1 line 0 comments Download
M src/regexp.js View 8 chunks +21 lines, -10 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +15 lines, -3 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/harmony/regexp-sticky.js View 1 chunk +132 lines, -0 lines 0 comments Download
A + test/mjsunit/regexp-not-sticky-yet.js View 1 chunk +30 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Erik Corry
4 years, 2 months ago (2014-09-19 07:10:39 UTC) #1
Sven Panne
LGTM (Yang is currently in a training)
4 years, 2 months ago (2014-09-19 07:31:08 UTC) #3
Yang
lgtm.
4 years, 2 months ago (2014-09-19 08:14:13 UTC) #4
Sven Panne
Can we actually land this now?
4 years, 2 months ago (2014-09-24 11:05:41 UTC) #5
Yang
4 years, 2 months ago (2014-09-25 13:16:36 UTC) #6
On 2014/09/24 11:05:41, Sven Panne wrote:
> Can we actually land this now?

Closing this as this has already been relanded.

Powered by Google App Engine
This is Rietveld 408576698