[Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc

Source/core/inspector/InspectorTraceEvents.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef InspectorTraceEvents_h
 #define InspectorTraceEvents_h
 
 #include "platform/EventTracer.h"
 #include "platform/TraceEvent.h"
+#include "platform/heap/Handle.h"
 #include "wtf/Forward.h"
 
 namespace blink {
 
+class DescendantInvalidationSet;
 class Document;
+class Element;
 class Event;
 class ExecutionContext;
 class FrameView;
 class GraphicsContext;
 class GraphicsLayer;
 class KURL;
 class LayoutRect;
 class LocalFrame;
 class RenderImage;
 class RenderLayer;
 class RenderObject;
 class ResourceRequest;
 class ResourceResponse;
 class ScriptSourceCode;
 class ScriptCallStack;
 class WorkerThread;
 class XMLHttpRequest;
 
 class InspectorLayoutEvent {
 public:
     static PassRefPtr<TraceEvent::ConvertableToTraceFormat> beginData(FrameView*);
     static PassRefPtr<TraceEvent::ConvertableToTraceFormat> endData(RenderObject* rootForThisLayout);
 };
 
+class InspectorStyleInvalidatorInvalidateEvent {

[caseq, 2014/09/30 12:24:00]

nit: here and below, I wonder if we need both Invalidator and Invalidate in one
identifier. InspectorStyleInvalidationEvent perhaps?

[kouhei (in TOK), 2014/10/01 04:16:14]

.
I think StyleInvalidatorInvalidate is correct here. This is recalcStyle
invalidation caused by StyleInvalidator, which precedes 
InspectorStyleRecalcInvalidationTrackingEvent.

+public:
+    static const char ElementHasPendingInvalidationMap[];
+    static const char InvalidateCustomPseudo[];
+    static const char InvalidationSetMatchedAttribute[];
+    static const char InvalidationSetMatchedClass[];
+    static const char InvalidationSetMatchedId[];
+    static const char InvalidationSetMatchedTagName[];
+    static const char PreventStyleSharingForParent[];
+
+    static PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(Element&, const char* reason, const String& = nullAtom);
+    static PassRefPtr<TraceEvent::ConvertableToTraceFormat> invalidationList(Element&, const WillBeHeapVector<RefPtrWillBeMember<DescendantInvalidationSet> >&);
+};
+#define TRACE_STYLE_INVALIDATOR_INVALIDATION(ELEMENT, REASON) \

[caseq, 2014/09/30 12:24:00]

nit: plase add a blank line above the macro definition. Also, lowercase the
macro parameters, they normally follow function arguments style.

[kouhei (in TOK), 2014/10/01 04:16:14]

Done.

+    TRACE_EVENT_INSTANT1( \
+        TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"), \
+        "StyleInvalidatorInvalidationTracking", \
+        "data", \
+        InspectorStyleInvalidatorInvalidateEvent::data((ELEMENT), (InspectorStyleInvalidatorInvalidateEvent::REASON)))
+#define TRACE_STYLE_INVALIDATOR_INVALIDATION_SELECTORPART(ELEMENT, REASON, SELECTORPART) \

[caseq, 2014/09/30 12:24:00]

ditto

[kouhei (in TOK), 2014/10/01 04:16:15]

Done.

+    TRACE_EVENT_INSTANT1( \
+        TRACE_DISABLED_BY_DEFAULT("devtools.timeline.invalidationTracking"), \
+        "StyleInvalidatorInvalidationTracking", \
+        "data", \
+        InspectorStyleInvalidatorInvalidateEvent::data((ELEMENT), (InspectorStyleInvalidatorInvalidateEvent::REASON), (SELECTORPART)))
+
 class InspectorLayoutInvalidationTrackingEvent {
 public:
     static PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const RenderObject*);
 };
 
 class InspectorPaintInvalidationTrackingEvent {
 public:
     static PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const RenderObject* renderer, const RenderObject* paintContainer);
 };
 
@@ skipping 132 matching lines @@
 
 class InspectorTracingSessionIdForWorkerEvent {
 public:
     static PassRefPtr<TraceEvent::ConvertableToTraceFormat> data(const String& sessionId, WorkerThread*);
 };
 
 } // namespace blink
 
 
 #endif // !defined(InspectorTraceEvents_h)