Source/core/css/invalidation/DescendantInvalidationSet.h - Issue 580373002: [Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc

Side by Side Diff: Source/core/css/invalidation/DescendantInvalidationSet.h

Issue 580373002: [Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: minimize diff Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2014 Google Inc. All rights reserved.	2 * Copyright (C) 2014 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 void setTreeBoundaryCrossing() { m_treeBoundaryCrossing = true; }	67 void setTreeBoundaryCrossing() { m_treeBoundaryCrossing = true; }

68 bool treeBoundaryCrossing() const { return m_treeBoundaryCrossing; }	68 bool treeBoundaryCrossing() const { return m_treeBoundaryCrossing; }

69	69

70 void setCustomPseudoInvalid() { m_customPseudoInvalid = true; }	70 void setCustomPseudoInvalid() { m_customPseudoInvalid = true; }

71 bool customPseudoInvalid() const { return m_customPseudoInvalid; }	71 bool customPseudoInvalid() const { return m_customPseudoInvalid; }

72	72

73 bool isEmpty() const { return !m_classes && !m_ids && !m_tagNames && !m_attr ibutes; }	73 bool isEmpty() const { return !m_classes && !m_ids && !m_tagNames && !m_attr ibutes; }

74	74

75 void trace(Visitor*);	75 void trace(Visitor*);

76	76

	77 // toString() is for debugging and tracing use only.

	78 String toString() const;
	pdr. 2014/09/30 02:08:49 Lets make it hard to use for anything else as a co Lets make it hard to use for anything else as a comment can be easy to miss :) String asTraceEventString() ? kouhei (in TOK) 2014/09/30 02:22:00 The tricky point is that this is also used inside Show quoted text On 2014/09/30 02:08:49, pdr wrote: > Lets make it hard to use for anything else as a comment can be easy to miss :) > > String asTraceEventString() ? The tricky point is that this is also used inside show(). pdr. 2014/09/30 03:21:57 show() is just for debugging though and is not use Show quoted text On 2014/09/30 02:22:00, kouhei wrote: > On 2014/09/30 02:08:49, pdr wrote: > > Lets make it hard to use for anything else as a comment can be easy to miss :) > > > > String asTraceEventString() ? > > The tricky point is that this is also used inside show(). show() is just for debugging though and is not used in any shipping code. Alternatively, "asDebugString()"? kouhei (in TOK) 2014/09/30 03:44:05 Done. Show quoted text On 2014/09/30 03:21:57, pdr wrote: > On 2014/09/30 02:22:00, kouhei wrote: > > On 2014/09/30 02:08:49, pdr wrote: > > > Lets make it hard to use for anything else as a comment can be easy to miss > :) > > > > > > String asTraceEventString() ? > > > > The tricky point is that this is also used inside show(). > > show() is just for debugging though and is not used in any shipping code. > Alternatively, "asDebugString()"? Done.
	79

77 #ifndef NDEBUG	80 #ifndef NDEBUG

78 void show() const;	81 void show() const;

79 #endif	82 #endif

80	83

81 private:	84 private:

82 DescendantInvalidationSet();	85 DescendantInvalidationSet();

83	86

84 WillBeHeapHashSet<AtomicString>& ensureClassSet();	87 WillBeHeapHashSet<AtomicString>& ensureClassSet();

85 WillBeHeapHashSet<AtomicString>& ensureIdSet();	88 WillBeHeapHashSet<AtomicString>& ensureIdSet();

86 WillBeHeapHashSet<AtomicString>& ensureTagNameSet();	89 WillBeHeapHashSet<AtomicString>& ensureTagNameSet();

(...skipping 11 matching lines...) Expand all Loading...
98 // If true, all descendants which are custom pseudo elements must be invalid ated.	101 // If true, all descendants which are custom pseudo elements must be invalid ated.

99 unsigned m_customPseudoInvalid : 1;	102 unsigned m_customPseudoInvalid : 1;

100	103

101 // If true, the invalidation must traverse into ShadowRoots with this set.	104 // If true, the invalidation must traverse into ShadowRoots with this set.

102 unsigned m_treeBoundaryCrossing : 1;	105 unsigned m_treeBoundaryCrossing : 1;

103 };	106 };

104	107

105 } // namespace blink	108 } // namespace blink

106	109

107 #endif // DescendantInvalidationSet_h	110 #endif // DescendantInvalidationSet_h

OLD	NEW

« no previous file with comments | « no previous file | Source/core/css/invalidation/DescendantInvalidationSet.cpp » ('j') | Source/core/css/invalidation/StyleInvalidator.cpp » ('J')