[Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc

Source/core/Init.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 28 matching lines @@
 #include "core/HTMLNames.h"
 #include "core/HTMLTokenizerNames.h"
 #include "core/InputTypeNames.h"
 #include "core/MathMLNames.h"
 #include "core/MediaFeatureNames.h"
 #include "core/MediaTypeNames.h"
 #include "core/SVGNames.h"
 #include "core/XLinkNames.h"
 #include "core/XMLNSNames.h"
 #include "core/XMLNames.h"
+#include "core/css/invalidation/DescendantInvalidationSet.h"
+#include "core/css/invalidation/StyleInvalidator.h"
 #include "core/dom/Document.h"
 #include "core/dom/StyleChangeReason.h"
 #include "core/events/EventFactory.h"
 #include "core/html/parser/HTMLParserThread.h"
 #include "core/workers/WorkerThread.h"
 #include "platform/EventTracer.h"
 #include "platform/FontFamilyNames.h"
 #include "platform/Partitions.h"
 #include "platform/PlatformThreadData.h"
 #include "platform/heap/Heap.h"
@@ skipping 35 matching lines @@
 
     // It would make logical sense to do this in WTF::initialize() but there are
     // ordering dependencies, e.g. about "xmlns".
     WTF::StringStatics::init();
 
     StyleChangeExtraData::init();
 
     QualifiedName::init();
     Partitions::init();
     EventTracer::initialize();
+    DescendantInvalidationSet::init(); // Depends on EventTracer::initialize()

[pdr., 2014/10/14 01:36:47]

Are these still needed?

[kouhei (in TOK), 2014/10/14 02:02:10]

Yes. These caches pointers to tracing flag. Accounts for 1-2% of overhead.

[kouhei (in TOK), 2014/10/14 04:18:13]

Discussed offline. I changed these flags to be initialized inside
StyleInvalidator c-tor.

+    StyleInvalidator::init(); // Depends on EventTracer::initialize()
 
     registerEventFactory();
 
     // Ensure that the main thread's thread-local data is initialized before
     // starting any worker threads.
     PlatformThreadData::current();
 
     StringImpl::freezeStaticStrings();
 
     // Creates HTMLParserThread::shared and ScriptStreamerThread::shared, but
     // does not start the threads.
     HTMLParserThread::init();
     ScriptStreamerThread::init();
 }
 
 void CoreInitializer::shutdown()
 {
     // Make sure we stop the HTMLParserThread and ScriptStreamerThread before
     // Platform::current() is cleared.
     ScriptStreamerThread::shutdown();
     HTMLParserThread::shutdown();
 
     // Make sure we stop WorkerThreads before Partition::shutdown() which frees ExecutionContext.
     WorkerThread::terminateAndWaitForAllWorkers();
 
     Partitions::shutdown();
 }
 
 } // namespace blink