Fix ObfuscatedFileUtil::DeleteDirectoryForOriginAndType() to support plugin private file system.

Fix ObfuscatedFileUtil::DeleteDirectoryForOriginAndType() to support plugin private file system.

This also enables user to clear plugin private file system using UI.

BUG=326429
TEST=Added new unittest.

[xhwang, 2014-09-19 04:47:19]

xhwang@chromium.org changed reviewers:
+ nhiroki@chromium.org, tzik@chromium.org

[xhwang, 2014-09-19 04:54:24]

xhwang@chromium.org changed reviewers:
+ kinuko@chromium.org

[xhwang, 2014-09-19 04:54:25]

nhiroki/tzik/kinuko: 

This CL clears the origin folder in Plugins/ but I guess the database isn't
cleared correctly. Please see my question below. Thanks!

https://codereview.chromium.org/580363003/diff/1/content/browser/fileapi/plug...
File content/browser/fileapi/plugin_private_file_system_backend_unittest.cc
(right):

https://codereview.chromium.org/580363003/diff/1/content/browser/fileapi/plug...
content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:285: }
This test is failing with this CL:

[ RUN      ] PluginPrivateFileSystemBackendTest.DeleteOriginDirectory
[26484:26484:0918/214357:129437815918:WARNING:obfuscated_file_util.cc(1043)]
Lost a backing file.
../../content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:269:
Failure
Value of: AsyncFileTestHelper::CreateFile(context_.get(), file1)
  Actual: -4
Expected: base::File::FILE_OK
Which is: 0
../../content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:271:
Failure
Value of: AsyncFileTestHelper::FileExists( context_.get(), file1,
AsyncFileTestHelper::kDontCheckSize)
  Actual: false
Expected: true
[26484:26484:0918/214357:129437821202:WARNING:obfuscated_file_util.cc(1043)]
Lost a backing file.
../../content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:284:
Failure
Value of: AsyncFileTestHelper::FileExists( context_.get(), file1,
AsyncFileTestHelper::kDontCheckSize)
  Actual: false
Expected: true
[  FAILED  ] PluginPrivateFileSystemBackendTest.DeleteOriginDirectory (288 ms)

I think I missed something. I don't know exactly what "Lost a backing file"
means. But it seems like the database isn't properly cleared. So when I try to
create the same file again, it tries to open the file, but cannot find it (-4:
NOT FOUND ERROR). So CreateFile() failed.

I did call
origin_database_->RemovePathForOrigin(storage::GetIdentifierFromOrigin(origin)))
which I thought would clear the database, but it seems I am still missing
something.

I spend a few hours on this but I don't really have the expertise in this area.
Any help or suggestions would be highly appreciated. Thanks!

[nhiroki, 2014-09-19 17:17:20]

Thank you working on this!

https://codereview.chromium.org/580363003/diff/1/content/browser/fileapi/plug...
File content/browser/fileapi/plugin_private_file_system_backend_unittest.cc
(right):

https://codereview.chromium.org/580363003/diff/1/content/browser/fileapi/plug...
content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:285: }
On 2014/09/19 04:54:24, xhwang wrote:
> This test is failing with this CL:
> 
> [ RUN      ] PluginPrivateFileSystemBackendTest.DeleteOriginDirectory
> [26484:26484:0918/214357:129437815918:WARNING:obfuscated_file_util.cc(1043)]
> Lost a backing file.
>
../../content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:269:
> Failure
> Value of: AsyncFileTestHelper::CreateFile(context_.get(), file1)
>   Actual: -4
> Expected: base::File::FILE_OK
> Which is: 0
>
../../content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:271:
> Failure
> Value of: AsyncFileTestHelper::FileExists( context_.get(), file1,
> AsyncFileTestHelper::kDontCheckSize)
>   Actual: false
> Expected: true
> [26484:26484:0918/214357:129437821202:WARNING:obfuscated_file_util.cc(1043)]
> Lost a backing file.
>
../../content/browser/fileapi/plugin_private_file_system_backend_unittest.cc:284:
> Failure
> Value of: AsyncFileTestHelper::FileExists( context_.get(), file1,
> AsyncFileTestHelper::kDontCheckSize)
>   Actual: false
> Expected: true
> [  FAILED  ] PluginPrivateFileSystemBackendTest.DeleteOriginDirectory (288 ms)
> 
> I think I missed something. I don't know exactly what "Lost a backing file"
> means.

"a backing file" means an actual file on the os-level filesystem specified by
the filesystem url. In this case, the file for |file1| was not found since you
already deleted whole origin directory at line 255.

> But it seems like the database isn't properly cleared.

You are right. There are two database here, namely, SandboxDirectoryDatabase
that manages directory metadata like "inode" and SandboxOriginDatabase that
manages origin directories. Probably we are missing to delete metadata from
SandboxDirectoryDatabase (see my comment in obfuscated_file_util.cc).

> So when I try to
> create the same file again, it tries to open the file, but cannot find it (-4:
> NOT FOUND ERROR). So CreateFile() failed.
>
> I did call
>
origin_database_->RemovePathForOrigin(storage::GetIdentifierFromOrigin(origin)))
> which I thought would clear the database, but it seems I am still missing
> something.
> 
> I spend a few hours on this but I don't really have the expertise in this
area.
> Any help or suggestions would be highly appreciated. Thanks!

https://codereview.chromium.org/580363003/diff/1/storage/browser/fileapi/obfu...
File storage/browser/fileapi/obfuscated_file_util.cc (right):

https://codereview.chromium.org/580363003/diff/1/storage/browser/fileapi/obfu...
storage/browser/fileapi/obfuscated_file_util.cc:872:
DestroyDirectoryDatabase(origin, type_string);
Probably we need to make DestroyDirectoryDatabase() callable for plugin private
filesystem to clean up the directory database.

[xhwang, 2014-09-26 18:20:16]

This CL is deprecated by https://codereview.chromium.org/579083004/