chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h - Issue 580363002: Update app info and install prompt UI to show retained devices.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h

Issue 580363002: Update app info and install prompt UI to show retained devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed feedback from Avi and tapted. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_install_prompt.cc ('K') | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm ('k') | chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h

diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h

index bc6fa6f31891f4cb530efd7f1a4e9be7fd0fe97c..5bb6c44d32e5c63d7a247e7b597ceff01bf04ee9 100644

--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h

+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h

@@ -57,9 +57,11 @@ class AppInfoPermissionsPanel : public AppInfoPanel,

// Internal initialisation methods.

void CreateActivePermissionsControl();

void CreateRetainedFilesControl();

+ void CreateRetainedDevicesControl();

void LayoutActivePermissionsControl();

void LayoutRetainedFilesControl();

+ void LayoutRetainedDevicesControl();

// Overridden from views::ButtonListener.

virtual void ButtonPressed(views::Button* sender,

@@ -68,6 +70,8 @@ class AppInfoPermissionsPanel : public AppInfoPanel,

const std::vector<base::string16> GetActivePermissionMessages() const;

const std::vector<base::string16> GetRetainedFilePaths() const;

void RevokeFilePermissions();

+ const std::vector<base::string16> GetRetainedDevices() const;

+ void RevokeDevicePermissions();

// UI elements on the dialog.

views::Label* active_permissions_heading_;

@@ -77,6 +81,10 @@ class AppInfoPermissionsPanel : public AppInfoPanel,

views::View* retained_files_list_;

views::LabelButton* revoke_file_permissions_button_;

+ views::Label* retained_devices_heading_;

+ views::View* retained_devices_list_;

+ views::LabelButton* revoke_device_permissions_button_;

DISALLOW_COPY_AND_ASSIGN(AppInfoPermissionsPanel);

};