Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5598)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 580363002: Update app info and install prompt UI to show retained devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
index e3417879bfa331a18ff86e66a2ac10b5e3908b8a..bf335ff24bb9c8d2d93fc2e4c0fab5f59895e997 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
#include "apps/app_load_service.h"
+#include "apps/saved_devices_service.h"
#include "apps/saved_files_service.h"
#include "base/base64.h"
#include "base/bind.h"
@@ -758,7 +759,13 @@ bool DeveloperPrivateShowPermissionsDialogFunction::RunSync() {
retained_file_paths.push_back(retained_file_entries[i].path);
}
}
- prompt_->ReviewPermissions(this, extension, retained_file_paths);
+ std::vector<base::string16> retained_device_messages;
+ if (extension->permissions_data()->HasAPIPermission(APIPermission::kUsb)) {
+ retained_device_messages = apps::SavedDevicesService::Get(GetProfile())
+ ->GetPermissionMessageStrings(extension_id_);
+ }
+ prompt_->ReviewPermissions(
+ this, extension, retained_file_paths, retained_device_messages);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698