Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 580343002: Add proto_java_library to gn (Closed)

Created:
6 years, 3 months ago by cjhopman
Modified:
6 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add proto_java_library to gn This adds a pretty straightforward gn template corresponding to protoc_java.gypi. protoc_java.py is updated to actually parse options instead of just using positional arguments. Adds cacheinvalidation targets. TBR=brettw, zea BUG=359249 Committed: https://crrev.com/a3f2d3f6819d1a6709a5a4d8fc62321e478bcc9f Cr-Commit-Position: refs/heads/master@{#297739}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Patch Set 4 : Rebase #

Patch Set 5 : = #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -37 lines) Patch
M build/config/android/rules.gni View 1 2 1 chunk +52 lines, -0 lines 0 comments Download
M build/protoc_java.gypi View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M build/protoc_java.py View 1 2 1 chunk +40 lines, -32 lines 0 comments Download
M build/secondary/third_party/cacheinvalidation/BUILD.gn View 1 2 3 1 chunk +30 lines, -1 line 0 comments Download
A third_party/android_protobuf/BUILD.gn View 1 2 1 chunk +138 lines, -0 lines 0 comments Download
M third_party/cacheinvalidation/cacheinvalidation.gyp View 1 6 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
cjhopman
nyquist: *
6 years, 3 months ago (2014-09-19 00:31:25 UTC) #3
nyquist
https://codereview.chromium.org/580343002/diff/40001/build/protoc_java.py File build/protoc_java.py (right): https://codereview.chromium.org/580343002/diff/40001/build/protoc_java.py#newcode9 build/protoc_java.py:9: protoc_java.py --protoc={protoc} --proto-dir={proto_path} {proto_files} I think you mean proto-path ...
6 years, 3 months ago (2014-09-22 21:25:17 UTC) #4
cjhopman
https://codereview.chromium.org/580343002/diff/40001/build/protoc_java.py File build/protoc_java.py (right): https://codereview.chromium.org/580343002/diff/40001/build/protoc_java.py#newcode9 build/protoc_java.py:9: protoc_java.py --protoc={protoc} --proto-dir={proto_path} {proto_files} On 2014/09/22 21:25:16, nyquist wrote: ...
6 years, 2 months ago (2014-09-26 23:39:10 UTC) #5
nyquist
lgtm
6 years, 2 months ago (2014-09-26 23:42:13 UTC) #6
cjhopman
brettw: TBRed for build/config/android zea: TBRed for third_party/cacheinvalidation
6 years, 2 months ago (2014-10-01 21:16:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580343002/80001
6 years, 2 months ago (2014-10-01 21:18:06 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/14402)
6 years, 2 months ago (2014-10-01 21:31:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580343002/100001
6 years, 2 months ago (2014-10-01 21:52:27 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:100001) as d79c969c0a129cc640e3d2c657ee95d7892b7965
6 years, 2 months ago (2014-10-01 23:49:06 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 23:50:31 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a3f2d3f6819d1a6709a5a4d8fc62321e478bcc9f
Cr-Commit-Position: refs/heads/master@{#297739}

Powered by Google App Engine
This is Rietveld 408576698