Add commit position to bisect result output.

tools/bisect-perf-regression.py

Index: tools/bisect-perf-regression.py
diff --git a/tools/bisect-perf-regression.py b/tools/bisect-perf-regression.py
old mode 100755
new mode 100644
index f67b2cad7cd986c03c85354788e40d9e3eb040db..50d972350a1bb2831aebb117b79e7fef8ab1be88
--- a/tools/bisect-perf-regression.py
+++ b/tools/bisect-perf-regression.py
@@ -2637,9 +2637,10 @@ class BisectPerformanceMetrics(object):
       warning = ''
     return confidence_status % {'level': level, 'warning': warning}
 
-  def _GetViewVCLinkFromDepotAndHash(self, cl, depot):
-    info = self.source_control.QueryRevisionInfo(cl,
-        self._GetDepotDirectory(depot))
+  def _GetViewVCLinkFromDepotAndHash(self, revision_id, depot):
+    """Gets link to the repository browser."""
+    info = self.source_control.QueryRevisionInfo(
+        revision_id, self._GetDepotDirectory(depot))
     if depot and DEPOT_DEPS_NAME[depot].has_key('viewvc'):
       try:
         # Format is "git-svn-id: svn://....@123456 <other data>"
@@ -2673,37 +2674,41 @@ class BisectPerformanceMetrics(object):
   def _PrintTestedCommitsHeader(self):
     if self.opts.bisect_mode == BISECT_MODE_MEAN:
       _PrintTableRow(
-          [20, 70, 14, 12, 13],
-          ['Depot', 'Commit SHA', 'Mean', 'Std. Error', 'State'])
+          [20, 12, 70, 14, 12, 13],
+          ['Depot', 'Position', 'SHA', 'Mean', 'Std. Error', 'State'])

[prasadv, 2014/09/24 21:48:36]

Can we use Commit-Position or Position-num

[chrisphan, 2014/09/24 21:56:50]

I was looking at the result in plain text, it might be easier to read using one
word.  What do you think?

     elif self.opts.bisect_mode == BISECT_MODE_STD_DEV:
       _PrintTableRow(
-          [20, 70, 14, 12, 13],
-          ['Depot', 'Commit SHA', 'Std. Error', 'Mean', 'State'])
+          [20, 12, 70, 14, 12, 13],
+          ['Depot', 'Position', 'SHA', 'Std. Error', 'Mean', 'State'])
     elif self.opts.bisect_mode == BISECT_MODE_RETURN_CODE:
       _PrintTableRow(
-          [20, 70, 14, 13],
-          ['Depot', 'Commit SHA', 'Return Code', 'State'])
+          [20, 12, 70, 14, 13],
+          ['Depot', 'Position', 'SHA', 'Return Code', 'State'])
     else:
       assert False, 'Invalid bisect_mode specified.'
 
-  def _PrintTestedCommitsEntry(self, current_data, cl_link, state_str):
+  def _PrintTestedCommitsEntry(self, current_data, commit_position, cl_link,
+                               state_str):
     if self.opts.bisect_mode == BISECT_MODE_MEAN:
       std_error = '+-%.02f' % current_data['value']['std_err']
       mean = '%.02f' % current_data['value']['mean']
       _PrintTableRow(
-          [20, 70, 12, 14, 13],
-          [current_data['depot'], cl_link, mean, std_error, state_str])
+          [20, 12, 70, 12, 14, 13],
+          [current_data['depot'], commit_position, cl_link, mean, std_error,
+           state_str])
     elif self.opts.bisect_mode == BISECT_MODE_STD_DEV:
       std_error = '+-%.02f' % current_data['value']['std_err']
       mean = '%.02f' % current_data['value']['mean']
       _PrintTableRow(
-          [20, 70, 12, 14, 13],
-          [current_data['depot'], cl_link, std_error, mean, state_str])
+          [20, 12, 70, 12, 14, 13],
+          [current_data['depot'], commit_position, cl_link, std_error, mean,
+           state_str])
     elif self.opts.bisect_mode == BISECT_MODE_RETURN_CODE:
       mean = '%d' % current_data['value']['mean']
       _PrintTableRow(
-          [20, 70, 14, 13],
-          [current_data['depot'], cl_link, mean, state_str])
+          [20, 12, 70, 14, 13],
+          [current_data['depot'], commit_position, cl_link, mean,
+           state_str])
 
   def _PrintTestedCommitsTable(
       self, revision_data_sorted, first_working_revision, last_broken_revision,
@@ -2743,7 +2748,9 @@ class BisectPerformanceMetrics(object):
             current_data['depot'])
         if not cl_link:
           cl_link = current_id
-        self._PrintTestedCommitsEntry(current_data, cl_link, state_str)
+        commit_position = self.source_control.GetCommitPosition(current_id)
+        self._PrintTestedCommitsEntry(current_data, commit_position, cl_link,
+                                      state_str)
 
   def _PrintReproSteps(self):
     """Prints out a section of the results explaining how to run the test.