|
|
DescriptionAdd commit position to bisect result output.
BUG=413772
NOTRY=true
Committed: https://crrev.com/e0f01f8d8c79983e2cceddfd655f51ea3bccc3a7
Cr-Commit-Position: refs/heads/master@{#296776}
Patch Set 1 #
Total comments: 2
Patch Set 2 : sync #Messages
Total messages: 18 (6 generated)
chrisphan@chromium.org changed reviewers: + prasadv@chromium.org
+reviewers
lgtm https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression... tools/bisect-perf-regression.py:2678: ['Depot', 'Position', 'SHA', 'Mean', 'Std. Error', 'State']) Can we use Commit-Position or Position-num
https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression... tools/bisect-perf-regression.py:2678: ['Depot', 'Position', 'SHA', 'Mean', 'Std. Error', 'State']) On 2014/09/24 21:48:36, prasadv wrote: > Can we use Commit-Position or Position-num I was looking at the result in plain text, it might be easier to read using one word. What do you think?
On 2014/09/24 21:56:50, chrisphan wrote: > https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py > File tools/bisect-perf-regression.py (right): > > https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression... > tools/bisect-perf-regression.py:2678: ['Depot', 'Position', 'SHA', 'Mean', 'Std. > Error', 'State']) > On 2014/09/24 21:48:36, prasadv wrote: > > Can we use Commit-Position or Position-num > > I was looking at the result in plain text, it might be easier to read using one > word. What do you think? lgtm
The CQ bit was checked by chrisphan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580293002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by chrisphan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580293002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by chrisphan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580293002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as c5f7b00a53528ec4d7e082bdc41948023e62398e
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/e0f01f8d8c79983e2cceddfd655f51ea3bccc3a7 Cr-Commit-Position: refs/heads/master@{#296776}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/608643002/ by fgorski@chromium.org. The reason for reverting is: Checkperms failure on https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%.... |