Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 580293002: Add commit position to bisect result output. (Closed)

Created:
6 years, 3 months ago by chrisphan
Modified:
6 years, 2 months ago
Reviewers:
prasadv
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add commit position to bisect result output. BUG=413772 NOTRY=true Committed: https://crrev.com/e0f01f8d8c79983e2cceddfd655f51ea3bccc3a7 Cr-Commit-Position: refs/heads/master@{#296776}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M tools/bisect-perf-regression.py View 1 3 chunks +24 lines, -17 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
chrisphan
+reviewers
6 years, 3 months ago (2014-09-18 21:29:42 UTC) #2
prasadv
lgtm https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py#newcode2678 tools/bisect-perf-regression.py:2678: ['Depot', 'Position', 'SHA', 'Mean', 'Std. Error', 'State']) Can ...
6 years, 3 months ago (2014-09-24 21:48:36 UTC) #3
chrisphan
https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py File tools/bisect-perf-regression.py (right): https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py#newcode2678 tools/bisect-perf-regression.py:2678: ['Depot', 'Position', 'SHA', 'Mean', 'Std. Error', 'State']) On 2014/09/24 ...
6 years, 3 months ago (2014-09-24 21:56:50 UTC) #4
prasadv
On 2014/09/24 21:56:50, chrisphan wrote: > https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py > File tools/bisect-perf-regression.py (right): > > https://codereview.chromium.org/580293002/diff/1/tools/bisect-perf-regression.py#newcode2678 > ...
6 years, 2 months ago (2014-09-25 16:43:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580293002/1
6 years, 2 months ago (2014-09-25 18:53:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13544)
6 years, 2 months ago (2014-09-25 19:03:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580293002/20001
6 years, 2 months ago (2014-09-25 19:27:03 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13556)
6 years, 2 months ago (2014-09-25 19:39:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580293002/20001
6 years, 2 months ago (2014-09-25 20:03:28 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c5f7b00a53528ec4d7e082bdc41948023e62398e
6 years, 2 months ago (2014-09-25 20:04:36 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e0f01f8d8c79983e2cceddfd655f51ea3bccc3a7 Cr-Commit-Position: refs/heads/master@{#296776}
6 years, 2 months ago (2014-09-25 20:05:21 UTC) #17
fgorski
6 years, 2 months ago (2014-09-25 20:33:36 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/608643002/ by fgorski@chromium.org.

The reason for reverting is: Checkperms failure on
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%....

Powered by Google App Engine
This is Rietveld 408576698