Add JsInitializerGenerator

lib/src/transformer/dart_initializer_generator.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library js.transformer.js_initializer_generator;
+library js.transformer.dart_initializer_generator;
 
 import 'package:js/src/js_elements.dart';
 import 'package:logging/logging.dart';
 import 'package:quiver/iterables.dart';
 
-final _logger = new Logger('js.transformer.js_initializer_generator');
+final _logger = new Logger('js.transformer.dart_initializer_generator');
 
 const JS_PREFIX = '__package_js_impl__';
 const JS_THIS_REF = '__js_this_ref__';
 
-class JsInitializerGenerator {
+class DartInitializerGenerator {
   final String libraryName;
   final String libraryPath;
   final JsElements jsElements;
 
   final buffer = new StringBuffer();
 
-  JsInitializerGenerator(this.libraryName, this.libraryPath, this.jsElements);
+  DartInitializerGenerator(this.libraryName, this.libraryPath, this.jsElements);
 
   /**
    * Returns the transformed source.
    */
   String generate() {
     buffer.write(
 '''
 library ${libraryName}__init_js__;
 
 import 'dart:js' as js;
@@ skipping 26 matching lines @@
 
   _generateLibraryExportCall(ExportedLibrary library) {
     buffer.writeln("  _export_${library.getPath('_')}(lib);");
   }
 
   _generateLibraryExportMethod(ExportedLibrary library) {
     buffer.writeln(
 '''
 
 void _export_${library.getPath('_')}($JS_PREFIX.JsObject parent) {
   JsObject lib = parent['${library.name}'];

[alexandre.ardhuin, 2014/09/19 12:38:59]

JsObject should be prefixed by "js."

[justinfagnani, 2014/09/23 01:29:53]

Done.

 ''');
 
     library.declarations.values.forEach(_generateDeclarationExportCall);
     library.children.values.forEach(_generateLibraryExportCall);
 
     buffer.writeln('}');
 
     library.children.values.forEach(_generateLibraryExportMethod);
     library.declarations.values.forEach(_generateDeclarationExport);
   }
@@ skipping 33 matching lines @@
     } else if (e is ExportedField) {
       _generateField(e);
     }
   }
 
   void _generateConstructor(ExportedConstructor c) {
     var constructorName = c.name == '' ? '_new' : '_new_${c.name}';
     var dartParameters = _getDartParameters(c.parameters);
     var jsParameters = _getJsParameters(c.parameters);
     var namedPart = c.name == '' ? '' : '.${c.name}';
-    buffer.writeln("  print('exporting constructor: ${constructorName}');");
     buffer.writeln("  constructor['$constructorName'] = ($jsParameters) => "
         "new ${c.parent.name}$namedPart($dartParameters);");
   }
 
   void _generateMethod(ExportedMethod c) {
     var dartParameters = _getDartParameters(c.parameters);
     var jsParameters = _getJsParameters(c.parameters, withThis: true);
     buffer.write(
 '''
 
   // method ${c.name}
   prototype['${c.name}'] = new js.JsFunction.withThis(($jsParameters) {
     return  $JS_THIS_REF.${c.name}($dartParameters);
   });
 ''');
   }
 
   void _generateField(ExportedField f) {

[alexandre.ardhuin, 2014/09/19 12:39:00]

static fields enter this function.

[justinfagnani, 2014/09/22 21:50:20]

I fixed this in the next CL

     var name = f.name;
     var className = f.parent.name;
     buffer.write(
 '''
   // field $name
   _obj.callMethod('defineProperty', [prototype, '$name',
       new js.JsObject.jsify({
         'get': new js.JsFunction.withThis((o) => (o[$JS_PREFIX.DART_OBJECT_PROPERTY] as $className).$name),
         'set': new js.JsFunction.withThis((o, v) => (o[$JS_PREFIX.DART_OBJECT_PROPERTY] as $className).$name = v),

[alexandre.ardhuin, 2014/09/19 12:39:00]

dart getters enter this function and shouldn't generate a setter.

[justinfagnani, 2014/09/22 21:50:20]

Fixed in the next CL

       })]);
 ''');
   }
 
 
   String _getJsParameters(List<ExportedParameter> parameters,
       {bool withThis: false}) {
     var requiredParameters = parameters
         .where((p) => p.kind == ParameterKind.REQUIRED)
         .map((p) => p.name);
@@ skipping 18 matching lines @@
     var requiredParameters = parameters
         .where((p) => p.kind == ParameterKind.REQUIRED)
         .map((p) => p.name);
     var positionalParameters = parameters
         .where((p) => p.kind == ParameterKind.POSITIONAL)
         .map((p) => p.name);
     var namedParameters = parameters
         .where((p) => p.kind == ParameterKind.NAMED)
         .map((p) => p.name);
     var dartNamedParameters = namedParameters.map((name) =>
         "${name}: _getOptionalArg(__js_named_parameters_map__, '${name}')");

[alexandre.ardhuin, 2014/09/19 12:38:59]

_getOptionalArg doesn't seem to be defined ?

[justinfagnani, 2014/09/22 21:50:20]

Acknowledged. I'll add tests for method invocation and fix this.

     var dartParameters = concat([
             requiredParameters,
             positionalParameters,
             dartNamedParameters])
         .join(', ');
 
     return dartParameters;
   }
 
 }