Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 580283003: Add extensions test data for an empty icon image (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add extensions test data for an empty icon image Part of extensions refactoring in https://codereview.chromium.org/562273006/ Landing manually because the tryjob patch step cannot handle empty binary files BUG=none TEST=none TBR=yoz@chromium.org Committed: https://crrev.com/2b9af8ed29f8db60324f10fce0f6bd3e8ae170a4 Cr-Commit-Position: refs/heads/master@{#295556}

Patch Set 1 #

Patch Set 2 : bad-icon no-find-copies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
A extensions/test/data/file_util/bad_icon/icon.png View 1 Binary file 0 comments Download
A extensions/test/data/file_util/bad_icon/manifest.json View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
Committed patchset #2 (id:20001) manually as 2b9af8e (presubmit successful).
6 years, 3 months ago (2014-09-18 21:39:42 UTC) #1
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:39:47 UTC) #2
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2b9af8ed29f8db60324f10fce0f6bd3e8ae170a4
Cr-Commit-Position: refs/heads/master@{#295556}

Powered by Google App Engine
This is Rietveld 408576698