Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 580263004: Remove EncryptedMediaAnyVersion runtime flag (status=stable) (Closed)

Created:
6 years, 3 months ago by heeyoun.lee
Modified:
6 years ago
Reviewers:
ddorwin, eseidel
CC:
blink-reviews, kangil_, pdr., tfarina
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove EncryptedMediaAnyVersion runtime flag (status=stable) BUG=402536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183353

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M Source/core/html/MediaError.idl View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/html/MediaKeyError.idl View 1 chunk +0 lines, -1 line 1 comment Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
heeyoun.lee
PTAL
6 years, 3 months ago (2014-09-19 07:19:27 UTC) #2
eseidel
lgtm
6 years, 2 months ago (2014-10-07 16:04:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580263004/1
6 years, 2 months ago (2014-10-07 16:05:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183353
6 years, 2 months ago (2014-10-07 17:11:36 UTC) #6
ddorwin
6 years ago (2014-12-11 19:29:08 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/602063003 contains the correct fix. These errors
need to be removed when prefixed EME is not supported.

https://codereview.chromium.org/580263004/diff/1/Source/core/html/MediaError.idl
File Source/core/html/MediaError.idl (right):

https://codereview.chromium.org/580263004/diff/1/Source/core/html/MediaError....
Source/core/html/MediaError.idl:34: [DeprecateAs=MediaErrorEncrypted] const
unsigned short MEDIA_ERR_ENCRYPTED = 5;
This should have been changed to PrefixedEncryptedMedia instead of deleted.

https://codereview.chromium.org/580263004/diff/1/Source/core/html/MediaKeyErr...
File Source/core/html/MediaKeyError.idl (right):

https://codereview.chromium.org/580263004/diff/1/Source/core/html/MediaKeyErr...
Source/core/html/MediaKeyError.idl:26: [
This should have been changed to PrefixedEncryptedMedia instead of deleted.

Powered by Google App Engine
This is Rietveld 408576698