chrome/browser/status_icons/desktop_notification_balloon.cc - Issue 580243004: Remove unnecessary image downloading handler of notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/status_icons/desktop_notification_balloon.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: re-upload Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_object_proxy.h ('K') | « chrome/browser/signin/signin_error_notifier_ash.cc ('k') | chrome/browser/sync/sync_error_notifier_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/status_icons/desktop_notification_balloon.cc

diff --git a/chrome/browser/status_icons/desktop_notification_balloon.cc b/chrome/browser/status_icons/desktop_notification_balloon.cc

index 85244df51dee3aa3f8fcbcb7b74222e6b97c6b34..890aeb4c4a229c403680dac840dae06e61741ba5 100644

--- a/chrome/browser/status_icons/desktop_notification_balloon.cc

+++ b/chrome/browser/status_icons/desktop_notification_balloon.cc

@@ -48,9 +48,6 @@ class DummyNotificationDelegate : public NotificationDelegate {

virtual void Close(bool by_user) OVERRIDE {}

virtual void Click() OVERRIDE {}

virtual std::string id() const OVERRIDE { return id_; }

- virtual content::WebContents* GetWebContents() const OVERRIDE {

- return NULL;

- }

private:

virtual ~DummyNotificationDelegate() {}