Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: chrome/browser/notifications/notification.h

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-upload Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.h
diff --git a/chrome/browser/notifications/notification.h b/chrome/browser/notifications/notification.h
index 0197b70f6529fe2bd001bfbcee974625c3838095..b7d05dbdcfa4497cb6da18d166e41962e63294d9 100644
--- a/chrome/browser/notifications/notification.h
+++ b/chrome/browser/notifications/notification.h
@@ -47,37 +47,15 @@ class Notification : public message_center::Notification {
// A unique identifier used to update (replace) or remove a notification.
const base::string16& replace_id() const { return replace_id_; }
- // A url for the button icons to be shown (optional).
- const GURL& button_one_icon_url() const { return button_one_icon_url_; }
- const GURL& button_two_icon_url() const { return button_two_icon_url_; }
-
- // A url for the image to be shown (optional).
- const GURL& image_url() const { return image_url_; }
-
// Id of the delegate embedded inside this instance.
std::string delegate_id() const { return delegate()->id(); }
- content::WebContents* GetWebContents() const {
- return delegate()->GetWebContents();
- }
- void DoneRendering() { delegate()->ReleaseRenderViewHost(); }
Peter Beverloo 2014/09/19 11:27:46 nit: These changes were part of my CL, and should
Jun Mukai 2014/09/19 22:34:29 rebased.
-
NotificationDelegate* delegate() const { return delegate_.get(); }
private:
// The Origin of the page/worker which created this notification.
GURL origin_url_;
- // The URLs of the button images for a rich notification.
- GURL button_one_icon_url_;
- GURL button_two_icon_url_;
-
- // The URL of a large image to be displayed for a a rich notification.
- GURL image_url_;
-
- // The URL of a small image to be displayed for a a rich notification.
- GURL small_image_url_;
-
// The user-supplied replace ID for the notification.
base::string16 replace_id_;

Powered by Google App Engine
This is Rietveld 408576698