Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-upload Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/message_center_notifications_browsertest.cc
diff --git a/chrome/browser/notifications/message_center_notifications_browsertest.cc b/chrome/browser/notifications/message_center_notifications_browsertest.cc
index 633d05621939bf4816fd31630215c06faa81f6bc..e769f691f763a77813a2a2b2a7b6930808e8f5a8 100644
--- a/chrome/browser/notifications/message_center_notifications_browsertest.cc
+++ b/chrome/browser/notifications/message_center_notifications_browsertest.cc
@@ -87,9 +87,6 @@ class MessageCenterNotificationsTest : public InProcessBrowserTest {
log_ += base::IntToString(button_index) + "_";
}
virtual std::string id() const OVERRIDE { return id_; }
- virtual content::WebContents* GetWebContents() const OVERRIDE {
- return NULL;
- }
const std::string& log() { return log_; }
@@ -109,13 +106,16 @@ class MessageCenterNotificationsTest : public InProcessBrowserTest {
new_delegate->AddRef();
}
- return Notification(GURL("chrome-test://testing/"),
- gfx::Image(),
+ return Notification(message_center::NOTIFICATION_TYPE_SIMPLE,
+ GURL("chrome-test://testing/"),
base::ASCIIToUTF16("title"),
base::ASCIIToUTF16("message"),
+ gfx::Image(),
blink::WebTextDirectionDefault,
+ message_center::NotifierId(),
base::UTF8ToUTF16("chrome-test://testing/"),
base::UTF8ToUTF16("REPLACE-ME"),
+ message_center::RichNotificationData(),
new_delegate);
}

Powered by Google App Engine
This is Rietveld 408576698