chrome/browser/notifications/notification.cc - Issue 580243004: Remove unnecessary image downloading handler of notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification.cc

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification.h ('k') | chrome/browser/notifications/notification_delegate.h » ('j') | ui/message_center/notifier_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification.cc

diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc

index a515d703e0ee41890f5204c35c75699a5b4a4e40..49d6fd63ef11a807163166911f108f1e881ef089 100644

--- a/chrome/browser/notifications/notification.cc

+++ b/chrome/browser/notifications/notification.cc

@@ -32,9 +32,6 @@ Notification::Notification(

Notification::Notification(const Notification& notification)

: message_center::Notification(notification),

origin_url_(notification.origin_url()),

- button_one_icon_url_(notification.button_one_icon_url()),

- button_two_icon_url_(notification.button_two_icon_url()),

- image_url_(notification.image_url()),

replace_id_(notification.replace_id()),

delegate_(notification.delegate()) {}

@@ -43,9 +40,6 @@ Notification::~Notification() {}

Notification& Notification::operator=(const Notification& notification) {

message_center::Notification::operator=(notification);

origin_url_ = notification.origin_url();

- button_one_icon_url_ = notification.button_one_icon_url();

- button_two_icon_url_ = notification.button_two_icon_url();

- image_url_ = notification.image_url();

replace_id_ = notification.replace_id();

delegate_ = notification.delegate();

return *this;