Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: ui/message_center/notifier_settings.h

Issue 580243004: Remove unnecessary image downloading handler of notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: build fix of desktop linux/win Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_MESSAGE_CENTER_NOTIFIER_SETTINGS_H_ 5 #ifndef UI_MESSAGE_CENTER_NOTIFIER_SETTINGS_H_
6 #define UI_MESSAGE_CENTER_NOTIFIER_SETTINGS_H_ 6 #define UI_MESSAGE_CENTER_NOTIFIER_SETTINGS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
11 #include "base/strings/string16.h" 11 #include "base/strings/string16.h"
12 #include "ui/gfx/image/image.h" 12 #include "ui/gfx/image/image.h"
13 #include "ui/message_center/message_center_export.h" 13 #include "ui/message_center/message_center_export.h"
14 #include "url/gurl.h" 14 #include "url/gurl.h"
15 15
16 class MessageCenterNotificationsTest;
16 class MessageCenterTrayBridgeTest; 17 class MessageCenterTrayBridgeTest;
18 class StubNotificationUIManager;
17 19
18 namespace ash { 20 namespace ash {
19 class WebNotificationTrayTest; 21 class WebNotificationTrayTest;
20 } 22 }
21 23
22 namespace message_center { 24 namespace message_center {
23 namespace test { 25 namespace test {
24 class MessagePopupCollectionTest; 26 class MessagePopupCollectionTest;
25 } 27 }
26 28
29 class MessageCenterNotificationManagerTest;
27 class NotifierSettingsDelegate; 30 class NotifierSettingsDelegate;
28 class NotifierSettingsProvider; 31 class NotifierSettingsProvider;
29 32
30 // Brings up the settings dialog and returns a weak reference to the delegate, 33 // Brings up the settings dialog and returns a weak reference to the delegate,
31 // which is typically the view. If the dialog already exists, it is brought to 34 // which is typically the view. If the dialog already exists, it is brought to
32 // the front, otherwise it is created. 35 // the front, otherwise it is created.
33 MESSAGE_CENTER_EXPORT NotifierSettingsDelegate* ShowSettings( 36 MESSAGE_CENTER_EXPORT NotifierSettingsDelegate* ShowSettings(
34 NotifierSettingsProvider* provider, 37 NotifierSettingsProvider* provider,
35 gfx::NativeView context); 38 gfx::NativeView context);
36 39
(...skipping 21 matching lines...) Expand all
58 std::string id; 61 std::string id;
59 62
60 // The URL pattern of the notifer. 63 // The URL pattern of the notifer.
61 GURL url; 64 GURL url;
62 65
63 // The identifier of the profile where the notification is created. This is 66 // The identifier of the profile where the notification is created. This is
64 // used for ChromeOS multi-profile support and can be empty. 67 // used for ChromeOS multi-profile support and can be empty.
65 std::string profile_id; 68 std::string profile_id;
66 69
67 private: 70 private:
68 friend class ::MessageCenterTrayBridgeTest; 71 friend class MessageCenterNotificationManagerTest;
69 friend class MessageCenterTrayTest; 72 friend class MessageCenterTrayTest;
70 friend class test::MessagePopupCollectionTest;
71 friend class NotificationControllerTest; 73 friend class NotificationControllerTest;
72 friend class PopupCollectionTest; 74 friend class PopupCollectionTest;
73 friend class TrayViewControllerTest; 75 friend class TrayViewControllerTest;
76 friend class ::MessageCenterNotificationsTest;
77 friend class ::MessageCenterTrayBridgeTest;
78 friend class ::StubNotificationUIManager;
74 friend class ash::WebNotificationTrayTest; 79 friend class ash::WebNotificationTrayTest;
80 friend class test::MessagePopupCollectionTest;
75 FRIEND_TEST_ALL_PREFIXES(PopupControllerTest, Creation); 81 FRIEND_TEST_ALL_PREFIXES(PopupControllerTest, Creation);
76 FRIEND_TEST_ALL_PREFIXES(NotificationListTest, UnreadCountNoNegative); 82 FRIEND_TEST_ALL_PREFIXES(NotificationListTest, UnreadCountNoNegative);
77 FRIEND_TEST_ALL_PREFIXES(NotificationListTest, TestHasNotificationOfType); 83 FRIEND_TEST_ALL_PREFIXES(NotificationListTest, TestHasNotificationOfType);
78 84
79 // The default constructor which doesn't specify the notifier. Used for tests. 85 // The default constructor which doesn't specify the notifier. Used for tests.
80 NotifierId(); 86 NotifierId();
81 }; 87 };
82 88
83 // The struct to hold the information of notifiers. The information will be 89 // The struct to hold the information of notifiers. The information will be
84 // used by NotifierSettingsView. 90 // used by NotifierSettingsView.
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 196
191 // Called upon request for more information about a particular notifier. 197 // Called upon request for more information about a particular notifier.
192 virtual void OnNotifierAdvancedSettingsRequested( 198 virtual void OnNotifierAdvancedSettingsRequested(
193 const NotifierId& notifier_id, 199 const NotifierId& notifier_id,
194 const std::string* notification_id) = 0; 200 const std::string* notification_id) = 0;
195 }; 201 };
196 202
197 } // namespace message_center 203 } // namespace message_center
198 204
199 #endif // UI_MESSAGE_CENTER_NOTIFIER_SETTINGS_H_ 205 #endif // UI_MESSAGE_CENTER_NOTIFIER_SETTINGS_H_
OLDNEW
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698