Remove unnecessary image downloading handler of notifications.

chrome/browser/notifications/message_center_notification_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NOTIFICATIONS_MESSAGE_CENTER_NOTIFICATION_MANAGER_H_
 #define CHROME_BROWSER_NOTIFICATIONS_MESSAGE_CENTER_NOTIFICATION_MANAGER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 82 matching lines @@
 
  protected:
   // content::NotificationObserver override.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
  private:
   FRIEND_TEST_ALL_PREFIXES(message_center::WebNotificationTrayTest,
                            ManuallyCloseMessageCenter);
-  class ImageDownloadsObserver {
-   public:
-    virtual void OnDownloadsCompleted() = 0;
-  };
-
-  typedef base::Callback<void(const gfx::Image&)> SetImageCallback;
-  class ImageDownloads
-      : public base::SupportsWeakPtr<ImageDownloads> {
-   public:
-    ImageDownloads(
-        message_center::MessageCenter* message_center,
-        ImageDownloadsObserver* observer);
-    virtual ~ImageDownloads();
-
-    void StartDownloads(const Notification& notification);
-    void StartDownloadWithImage(const Notification& notification,
-                                const gfx::Image* image,
-                                const GURL& url,
-                                const SetImageCallback& callback);
-    void StartDownloadByKey(const Notification& notification,
-                            const char* key,
-                            int size,
-                            const SetImageCallback& callback);
-
-    // FaviconHelper callback.
-    void DownloadComplete(const SetImageCallback& callback,
-                          int download_id,
-                          int http_status_code,
-                          const GURL& image_url,
-                          const std::vector<SkBitmap>& bitmaps,
-                          const std::vector<gfx::Size>& original_bitmap_sizes);
-   private:
-    // Used to keep track of the number of pending downloads.  Once this
-    // reaches zero, we can tell the delegate that we don't need the
-    // RenderViewHost anymore.
-    void AddPendingDownload();
-    void PendingDownloadCompleted();
-
-    // Weak reference to global message center.
-    message_center::MessageCenter* message_center_;
-
-    // Count of downloads that remain.
-    size_t pending_downloads_;
-
-    // Weak.
-    ImageDownloadsObserver* observer_;
-
-    DISALLOW_COPY_AND_ASSIGN(ImageDownloads);
-  };
 
   // This class keeps a set of original Notification objects and corresponding
   // Profiles, so when MessageCenter calls back with a notification_id, this
   // class has necessary mapping to other source info - for example, it calls
   // NotificationDelegate supplied by client when someone clicks on a
   // Notification in MessageCenter. Likewise, if a Profile or Extension is
   // being removed, the  map makes it possible to revoke the notifications from
   // MessageCenter.   To keep that set, we use the private ProfileNotification
   // class that stores  a superset of all information about a notification.
 
   // TODO(dimich): Consider merging all 4 types (Notification,
   // QueuedNotification, ProfileNotification and NotificationList::Notification)
   // into a single class.
-  class ProfileNotification : public ImageDownloadsObserver {
+  class ProfileNotification {
    public:
     ProfileNotification(Profile* profile,
                         const Notification& notification,
                         message_center::MessageCenter* message_center);
     virtual ~ProfileNotification();
 
-    void StartDownloads();
-
-    // Overridden from ImageDownloadsObserver.
-    virtual void OnDownloadsCompleted() OVERRIDE;
-
     Profile* profile() const { return profile_; }
     const Notification& notification() const { return notification_; }
 
     // Route a new notification to an app/extension.
     void AddToAlternateProvider(const std::string extension_id);
 
    private:
     // Weak, guaranteed not to be used after profile removal by parent class.
     Profile* profile_;
     Notification notification_;
-    // Track the downloads for this notification so the notification can be
-    // updated properly.
-    scoped_ptr<ImageDownloads> downloads_;
   };
 
   scoped_ptr<message_center::MessageCenterTrayDelegate> tray_;
   message_center::MessageCenter* message_center_;  // Weak, global.
 
   // Use a map by notification_id since this mapping is the most often used.
   typedef std::map<std::string, ProfileNotification*> NotificationMap;
   NotificationMap profile_notifications_;
 
   // Helpers that add/remove the notification from local map.
@@ skipping 44 matching lines @@
   // Keeps track of all notification statistics for UMA purposes.
   MessageCenterStatsCollector stats_collector_;
 
   // Keeps track of notifications specific to Google Now for UMA purposes.
   GoogleNowNotificationStatsCollector google_now_stats_collector_;
 
   DISALLOW_COPY_AND_ASSIGN(MessageCenterNotificationManager);
 };
 
 #endif  // CHROME_BROWSER_NOTIFICATIONS_MESSAGE_CENTER_NOTIFICATION_MANAGER_H_