Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 580233003: Revert of Roll asan_symbolize.py to llvm r218071. (Closed)

Created:
6 years, 3 months ago by earthdok
Modified:
6 years, 3 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll asan_symbolize.py to llvm r218071. (patchset #2 id:20001 of https://codereview.chromium.org/584673002/) Reason for revert: This requires an accompanying change to the Chromium-specific wrapper. NOTRY=true Original issue's description: > Roll asan_symbolize.py to llvm r218071. > > This fixes an issue with missing newlines in stacktraces. > > BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343 > TBR=glider@chromium.org > NOTRY=true > > Committed: https://crrev.com/f7aef702936dcd93ab4928ead74e3db437c1f862 > Cr-Commit-Position: refs/heads/master@{#295531} TBR=glider@chromium.org NOTREECHECKS=true NOTRY=true BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343 Committed: https://crrev.com/c11fe9bc0a9cc225f4d734a3df1c315fc7c1ba42 Cr-Commit-Position: refs/heads/master@{#295535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -55 lines) Patch
M tools/valgrind/asan/third_party/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/asan/third_party/asan_symbolize.py View 8 chunks +18 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
Created Revert of Roll asan_symbolize.py to llvm r218071.
6 years, 3 months ago (2014-09-18 19:53:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580233003/1
6 years, 3 months ago (2014-09-18 19:53:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6f623179a83cddea3f603838d83f811eb00946ff
6 years, 3 months ago (2014-09-18 19:54:37 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 19:55:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c11fe9bc0a9cc225f4d734a3df1c315fc7c1ba42
Cr-Commit-Position: refs/heads/master@{#295535}

Powered by Google App Engine
This is Rietveld 408576698