Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 580233002: Add STS and PKP preloads for chrome.com. (Closed)

Created:
6 years, 3 months ago by palmer
Modified:
5 years, 8 months ago
Reviewers:
agl, rpop, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add STS and PKP preloads for chrome.com. BUG=415689 Committed: https://crrev.com/3fb1abc3dd53784b276213c14283a7c364ca1b27 Cr-Commit-Position: refs/heads/master@{#316935}

Patch Set 1 #

Patch Set 2 : Rebase and re-generate the .h file. #

Patch Set 3 : Rebase again, regenerate .h again. #

Total comments: 2

Patch Set 4 : Add new domains to the END of the array. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1265 lines, -1261 lines) Patch
M net/http/transport_security_state_static.h View 1 2 3 2 chunks +1262 lines, -1260 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
palmer
* Is it actually OK to pin chrome.com? * How concerned should we be that ...
6 years, 3 months ago (2014-09-18 19:38:53 UTC) #2
Ryan Sleevi
Ping? Abandoned?
6 years, 1 month ago (2014-10-27 22:00:19 UTC) #3
palmer
> Ping? Abandoned? Not abandoned, just InternalDependency.
6 years, 1 month ago (2014-10-27 22:43:11 UTC) #4
palmer
> Not abandoned, just InternalDependency. Internal dependency resolved. PTAL. Thanks!
5 years, 10 months ago (2015-02-09 20:25:06 UTC) #6
Ryan Sleevi
Not LGTM for a somewhat trivial, but critical, issue. https://codereview.chromium.org/580233002/diff/40001/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/580233002/diff/40001/net/http/transport_security_state_static.json#newcode1855 net/http/transport_security_state_static.json:1855: ...
5 years, 10 months ago (2015-02-09 22:26:08 UTC) #7
lgarron
On 2015/02/09 at 22:26:08, rsleevi wrote: > Not LGTM for a somewhat trivial, but critical, ...
5 years, 10 months ago (2015-02-18 01:02:13 UTC) #8
Ryan Sleevi
lgtm
5 years, 10 months ago (2015-02-18 22:04:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580233002/60001
5 years, 10 months ago (2015-02-18 22:06:09 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-19 00:42:12 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3fb1abc3dd53784b276213c14283a7c364ca1b27 Cr-Commit-Position: refs/heads/master@{#316935}
5 years, 10 months ago (2015-02-19 00:42:45 UTC) #13
palmer
5 years, 8 months ago (2015-03-31 22:21:38 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/580233002/diff/40001/net/http/transport_secur...
File net/http/transport_security_state_static.json (right):

https://codereview.chromium.org/580233002/diff/40001/net/http/transport_secur...
net/http/transport_security_state_static.json:1855: // domains at the END of the
array.
> *cough cough*

Fixed.

Powered by Google App Engine
This is Rietveld 408576698