Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 580213003: gn: gyp_flag_compare.py de-escape command line properly (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: gyp_flag_compare.py de-escape command line properly Makes some Skia flags be matched properly. e.g. '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' vs -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\" Diffs 393202 -> 374424. It does make the script quite a bit slower unfortunately, I guess the regular split is native C. BUG=335824 Committed: https://crrev.com/8034e1d4dc0524ef8477e475b771c4b080e6dce2 Cr-Commit-Position: refs/heads/master@{#295562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/gn/bin/gyp_flag_compare.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
6 years, 3 months ago (2014-09-18 20:00:23 UTC) #2
brettw
lgtm
6 years, 3 months ago (2014-09-18 20:14:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580213003/1
6 years, 3 months ago (2014-09-18 20:18:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ba24037b1b8782d4838e97431e33191db710c03c
6 years, 3 months ago (2014-09-18 21:45:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:46:50 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8034e1d4dc0524ef8477e475b771c4b080e6dce2
Cr-Commit-Position: refs/heads/master@{#295562}

Powered by Google App Engine
This is Rietveld 408576698