Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 580203002: Set orientation to 'AUTO' if we hide orientation option from user. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set orientation to 'AUTO' if we hide orientation option from user. BUG=383877 Committed: https://crrev.com/317e48ff59b1e42c730c1edbc494bd3f67079ead Cr-Commit-Position: refs/heads/master@{#295545}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Thu Sep 18 12:07:42 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/data/ticket_items/landscape.js View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-18 18:35:49 UTC) #2
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/580203002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/landscape.js File chrome/browser/resources/print_preview/data/ticket_items/landscape.js (right): https://codereview.chromium.org/580203002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/landscape.js#newcode94 chrome/browser/resources/print_preview/data/ticket_items/landscape.js:94: // TODO(vitalybuka): For landscape PDF dimmensions should be ...
6 years, 3 months ago (2014-09-18 19:03:01 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/580203002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/landscape.js File chrome/browser/resources/print_preview/data/ticket_items/landscape.js (right): https://codereview.chromium.org/580203002/diff/1/chrome/browser/resources/print_preview/data/ticket_items/landscape.js#newcode94 chrome/browser/resources/print_preview/data/ticket_items/landscape.js:94: // TODO(vitalybuka): For landscape PDF dimmensions should be On ...
6 years, 3 months ago (2014-09-18 19:08:47 UTC) #4
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-18 19:11:09 UTC) #6
Lei Zhang
lgtm stamp
6 years, 3 months ago (2014-09-18 19:20:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580203002/20001
6 years, 3 months ago (2014-09-18 19:21:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as be279069837e9baf61a9c2156a8ab7929fc86ec7
6 years, 3 months ago (2014-09-18 20:22:14 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 20:22:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/317e48ff59b1e42c730c1edbc494bd3f67079ead
Cr-Commit-Position: refs/heads/master@{#295545}

Powered by Google App Engine
This is Rietveld 408576698