Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3191)

Unified Diff: chrome/installer/setup/uninstall.cc

Issue 58019: Delete Chrome extensions related registry entries on uninstall. (Closed)
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/uninstall.cc
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc
index d0b65ae1584f9f2f1ecad65728cacd2b9bc52772..05b7f63e6a6a309dd632ff933ef053b89b433de6 100644
--- a/chrome/installer/setup/uninstall.cc
+++ b/chrome/installer/setup/uninstall.cc
@@ -242,11 +242,20 @@ installer_util::InstallStatus installer_setup::UninstallChrome(
DeleteRegistryKey(key, dist->GetVersionKey());
// Delete Software\Classes\ChromeHTML,
+ // Delete Software\Classes\ChromeExt,
+ // Delete Software\Classes\.crx,
// Software\Clients\StartMenuInternet\chrome.exe and
// Software\RegisteredApplications\Chrome
std::wstring html_prog_id(ShellUtil::kRegClasses);
file_util::AppendToPath(&html_prog_id, ShellUtil::kChromeHTMLProgId);
DeleteRegistryKey(key, html_prog_id);
+ std::wstring ext_prog_id(ShellUtil::kRegClasses);
+ file_util::AppendToPath(&ext_prog_id, ShellUtil::kChromeExtProgId);
+ DeleteRegistryKey(key, ext_prog_id);
+ std::wstring ext_association(ShellUtil::kRegClasses);
+ ext_association.append(L".");
+ ext_association.append(chrome::kExtensionFileExtension);
+ DeleteRegistryKey(key, ext_association);
std::wstring set_access_key(ShellUtil::kRegStartMenuInternet);
file_util::AppendToPath(&set_access_key, dist->GetApplicationName());
@@ -285,6 +294,8 @@ installer_util::InstallStatus installer_setup::UninstallChrome(
if (remove_all) {
DeleteRegistryKey(hklm_key, set_access_key);
DeleteRegistryKey(hklm_key, html_prog_id);
+ DeleteRegistryKey(hklm_key, ext_prog_id);
+ DeleteRegistryKey(hklm_key, ext_association);
DeleteRegistryValue(HKEY_LOCAL_MACHINE,
ShellUtil::kRegRegisteredApplications,
dist->GetApplicationName());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698