Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 580173004: roll pdfium to e0399c76 (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
Tom Sepez, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

roll pdfium to e0399c76 Changes include: e0399c7 Fix Regression: Incomplete file loading is seen for multi page pdf files. 9135010 gn: don't remove -fno-exceptions to match gyp 69dcf14 When forcing clear page data, no need to release colorspace when releasing pattern 4481496 Add a boundary check before accessing the table of 'Index to Location' 4cce875 Check Null pointer in CPDF_Dictionary::GetUnicodeText 56ef173 Fix hebrew character highlight issue in a special document TBR=jam@chromium.org BUG= Committed: https://crrev.com/cb360d31d86e50fbd71c40030b423e3fc263c184 Cr-Commit-Position: refs/heads/master@{#295555}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
6 years, 3 months ago (2014-09-18 19:34:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580173004/1
6 years, 3 months ago (2014-09-18 19:35:28 UTC) #4
Tom Sepez
On 2014/09/18 19:34:35, scottmg wrote: LGTM. Thanks for doing this. nit: in the CL description, ...
6 years, 3 months ago (2014-09-18 19:36:43 UTC) #5
scottmg
Ah, I did git log --pretty=oneline. Options are great, let's have lots! Updated. On Thu, ...
6 years, 3 months ago (2014-09-18 19:39:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as d323e81c343f24eff82070fea0a5182ce8896634
6 years, 3 months ago (2014-09-18 21:38:15 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:39:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb360d31d86e50fbd71c40030b423e3fc263c184
Cr-Commit-Position: refs/heads/master@{#295555}

Powered by Google App Engine
This is Rietveld 408576698