Issue 580143002: Revert of easy-unlock: Only show "Set up" UI for en-US.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 580143002: Revert of easy-unlock: Only show "Set up" UI for en-US. (Closed)

Created:
6 years, 3 months ago by xiyuan

Modified:
6 years, 3 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of easy-unlock: Only show "Set up" UI for en-US. (patchset #1 id:1 of https://codereview.chromium.org/567643003/) Reason for revert: en-US only is meant for M38. Revert to re-enable setup for all locales. Original issue's description: > easy-unlock: Only show "Set up" UI for en-US. > > BUG=414467 > > Committed: https://crrev.com/78d93d0e19bbb635c4bfe6cb7dab0db26d04598c > Cr-Commit-Position: refs/heads/master@{#295156} TBR=isherman@chromium.org NOTREECHECKS=true NOTRY=true BUG=414467 Committed: https://crrev.com/d9ca17cf109b060ea9838f08c940d399a652d771 Cr-Commit-Position: refs/heads/master@{#295485}

Created: 6 years, 3 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	chrome/browser/resources/options/browser_options.js	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Total messages: 4 (0 generated)

xiyuan

Created Revert of easy-unlock: Only show "Set up" UI for en-US.

6 years, 3 months ago (2014-09-18 17:02:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580143002/1

6 years, 3 months ago (2014-09-18 17:04:07 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as f01324702cae2bca8edde99453f12cbfec49e09d

6 years, 3 months ago (2014-09-18 17:04:58 UTC) #3

commit-bot: I haz the power

6 years, 3 months ago (2014-09-18 17:05:53 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d9ca17cf109b060ea9838f08c940d399a652d771
Cr-Commit-Position: refs/heads/master@{#295485}