chrome/browser/captive_portal/captive_portal_tab_helper.cc - Issue 580133002: Update entry page type to include error pages when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/captive_portal/captive_portal_tab_helper.cc

Issue 580133002: Update entry page type to include error pages when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile fix for unit_tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/captive_portal/captive_portal_tab_helper.h ('k') | chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc » ('j') | content/browser/frame_host/navigation_controller_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/captive_portal/captive_portal_tab_helper.cc

diff --git a/chrome/browser/captive_portal/captive_portal_tab_helper.cc b/chrome/browser/captive_portal/captive_portal_tab_helper.cc

index bd4895ba17342cc89d57e098a669ab17a8d0c978..957e660e299eeda424f93e2dce97c6bbab958065 100644

--- a/chrome/browser/captive_portal/captive_portal_tab_helper.cc

+++ b/chrome/browser/captive_portal/captive_portal_tab_helper.cc

@@ -100,6 +100,7 @@ void CaptivePortalTabHelper::DidStartProvisionalLoadForFrame(

void CaptivePortalTabHelper::DidCommitProvisionalLoadForFrame(

content::RenderFrameHost* render_frame_host,

const GURL& url,

+ bool url_is_unreachable,

ui::PageTransition transition_type) {

DCHECK(CalledOnValidThread());