content/browser/frame_host/navigation_controller_impl.cc - Issue 580133002: Update entry page type to include error pages when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 580133002: Update entry page type to include error pages when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address suggestions. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 3b53e5844f1548ed984d2a1bfb7e6bc31a18fa66..4be5a3ce4a009f07a74d87de92730bec3740c2b7 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1060,6 +1060,8 @@ void NavigationControllerImpl::RendererDidNavigateToNewPage(

update_virtual_url = needs_update;

}

+ if (params.url_is_unreachable)

+ new_entry->set_page_type(PAGE_TYPE_ERROR);

new_entry->SetURL(params.url);

if (update_virtual_url)

UpdateVirtualURLToURL(new_entry, params.url);

« no previous file with comments | « chrome/browser/ui/zoom/zoom_controller_unittest.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »