content/common/frame_messages.h - Issue 580133002: Update entry page type to include error pages when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 580133002: Update entry page type to include error pages when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix/improve tests. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/zoom/zoom_controller.cc ('K') | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 1bc23d20472c0e1a14af69ab1a4564eb7f435e1d..442295891440c934490218edba3976dbd33b90e1 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -141,6 +141,11 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,

// The status code of the HTTP request.

IPC_STRUCT_MEMBER(int, http_status_code)

+ // This flag is used to warn if the renderer is displaying an error page,

+ // so that we can set the appropriate page type. Some services, such as

Charlie Reis 2014/09/24 16:43:43 nit: We don't need the second sentence, just in ca

wjmaclean 2014/09/24 17:59:11 Done.

+ // page zoom, should not operate on error pages.

+ IPC_STRUCT_MEMBER(bool, url_is_unreachable)

// True if the connection was proxied. In this case, socket_address

// will represent the address of the proxy, rather than the remote host.

IPC_STRUCT_MEMBER(bool, was_fetched_via_proxy)

« chrome/browser/ui/zoom/zoom_controller.cc ('K') | « content/browser/frame_host/navigation_controller_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »