Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Side by Side Diff: chrome/browser/ui/zoom/zoom_controller_browsertest.cc

Issue 580133002: Update entry page type to include error pages when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix/improve tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/zoom/zoom_controller.h" 5 #include "chrome/browser/ui/zoom/zoom_controller.h"
6 6
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "base/process/kill.h" 8 #include "base/process/kill.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/tabs/tab_strip_model.h" 11 #include "chrome/browser/ui/tabs/tab_strip_model.h"
12 #include "chrome/common/pref_names.h" 12 #include "chrome/common/pref_names.h"
13 #include "chrome/test/base/in_process_browser_test.h" 13 #include "chrome/test/base/in_process_browser_test.h"
14 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
15 #include "content/public/browser/navigation_entry.h"
15 #include "content/public/browser/render_process_host.h" 16 #include "content/public/browser/render_process_host.h"
16 #include "content/public/browser/render_view_host.h" 17 #include "content/public/browser/render_view_host.h"
17 #include "content/public/browser/web_contents.h" 18 #include "content/public/browser/web_contents.h"
19 #include "content/public/common/page_type.h"
18 #include "content/public/test/browser_test_utils.h" 20 #include "content/public/test/browser_test_utils.h"
19 #include "testing/gmock/include/gmock/gmock.h" 21 #include "testing/gmock/include/gmock/gmock.h"
20 22
21 typedef InProcessBrowserTest ZoomControllerBrowserTest; 23 typedef InProcessBrowserTest ZoomControllerBrowserTest;
22 24
23 bool operator==(const ZoomController::ZoomChangedEventData& lhs, 25 bool operator==(const ZoomController::ZoomChangedEventData& lhs,
24 const ZoomController::ZoomChangedEventData& rhs) { 26 const ZoomController::ZoomChangedEventData& rhs) {
25 return lhs.web_contents == rhs.web_contents && 27 return lhs.web_contents == rhs.web_contents &&
26 lhs.old_zoom_level == rhs.old_zoom_level && 28 lhs.old_zoom_level == rhs.old_zoom_level &&
27 lhs.new_zoom_level == rhs.new_zoom_level && 29 lhs.new_zoom_level == rhs.new_zoom_level &&
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 true); 106 true);
105 ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data); 107 ZoomChangedWatcher zoom_change_watcher(web_contents, zoom_change_data);
106 // TODO(wjmaclean): Convert this to call partition-specific zoom level prefs 108 // TODO(wjmaclean): Convert this to call partition-specific zoom level prefs
107 // when they become available. 109 // when they become available.
108 browser()->profile()->GetPrefs()->SetDouble(prefs::kDefaultZoomLevel, 110 browser()->profile()->GetPrefs()->SetDouble(prefs::kDefaultZoomLevel,
109 new_default_zoom_level); 111 new_default_zoom_level);
110 // Because this test relies on a round-trip IPC to/from the renderer process, 112 // Because this test relies on a round-trip IPC to/from the renderer process,
111 // we need to wait for it to propagate. 113 // we need to wait for it to propagate.
112 zoom_change_watcher.Wait(); 114 zoom_change_watcher.Wait();
113 } 115 }
116
117 IN_PROC_BROWSER_TEST_F(ZoomControllerBrowserTest, ErrorPagesDoNotZoom) {
118 ui_test_utils::NavigateToURL(browser(), GURL("http://kjfhkjsdf.com"));
119 content::WebContents* web_contents =
120 browser()->tab_strip_model()->GetActiveWebContents();
121
122 ZoomController* zoom_controller =
123 ZoomController::FromWebContents(web_contents);
124 EXPECT_EQ(
125 content::PAGE_TYPE_ERROR,
126 web_contents->GetController().GetLastCommittedEntry()->GetPageType());
127
128 double old_zoom_level = zoom_controller->GetZoomLevel();
129 double new_zoom_level = old_zoom_level + 0.5;
130
131 // The following attempt to change the zoom level for an error page should
132 // fail.
133 zoom_controller->SetZoomLevel(new_zoom_level);
134 EXPECT_FLOAT_EQ(old_zoom_level, zoom_controller->GetZoomLevel());
135 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698