Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: mojo/system/channel.cc

Issue 580123004: Mojo: Remove knowledge of Channel, etc. from ProxyMessagePipeEndpoint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/system/channel_endpoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/channel.cc
diff --git a/mojo/system/channel.cc b/mojo/system/channel.cc
index 3a87b01401808981ea98ac9ad42974abbe112a06..98dc511668e31f02987d84c3dab5b7534b1afe10 100644
--- a/mojo/system/channel.cc
+++ b/mojo/system/channel.cc
@@ -119,7 +119,7 @@ MessageInTransit::EndpointId Channel::AttachMessagePipeEndpoint(
endpoint->AttachToChannel(this, local_id);
// This might fail if that port got an |OnPeerClose()| before attaching.
- if (message_pipe->Attach(port, endpoint.get(), this, local_id))
+ if (message_pipe->Attach(port, endpoint.get()))
return local_id;
// Note: If it failed, quite possibly the endpoint info was removed from that
@@ -180,7 +180,7 @@ bool Channel::RunMessagePipeEndpoint(MessageInTransit::EndpointId local_id,
// running when we're here due to |kSubtypeChannelRunMessagePipeEndpoint|).
endpoint->Run(remote_id);
// TODO(vtl): Get rid of this.
- message_pipe->Run(port, remote_id);
+ message_pipe->Run(port);
return true;
}
« no previous file with comments | « no previous file | mojo/system/channel_endpoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698