Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 580123004: Mojo: Remove knowledge of Channel, etc. from ProxyMessagePipeEndpoint. (Closed)

Created:
6 years, 3 months ago by viettrungluu
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Remove knowledge of Channel, etc. from ProxyMessagePipeEndpoint. R=darin@chromium.org Committed: https://crrev.com/fc032c34a1b4fa7ba05dfdfc80c57011a9088583 Cr-Commit-Position: refs/heads/master@{#295550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -108 lines) Patch
M mojo/system/channel.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/system/channel_endpoint.h View 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/system/channel_endpoint.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M mojo/system/message_pipe.h View 2 chunks +2 lines, -6 lines 0 comments Download
M mojo/system/message_pipe.cc View 1 chunk +4 lines, -10 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 2 chunks +2 lines, -5 lines 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 3 chunks +7 lines, -30 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 5 chunks +16 lines, -51 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 3 months ago (2014-09-18 19:08:39 UTC) #1
darin (slow to review)
lgtm
6 years, 3 months ago (2014-09-18 19:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580123004/1
6 years, 3 months ago (2014-09-18 20:07:17 UTC) #4
viettrungluu
Committed patchset #1 (id:1) manually as fc032c3 (presubmit successful).
6 years, 3 months ago (2014-09-18 21:33:07 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 21:33:07 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fc032c34a1b4fa7ba05dfdfc80c57011a9088583
Cr-Commit-Position: refs/heads/master@{#295550}

Powered by Google App Engine
This is Rietveld 408576698