Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 580093005: Fix the loop behavior on android (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the loop behavior on android During loop, player should not be in a paused state This change fix that behavior Layout test:https://codereview.chromium.org/585563003/ BUG=415651 Committed: https://crrev.com/5f328dba01c4ed670a0e4a3d222545c52561a5dd Cr-Commit-Position: refs/heads/master@{#295585}

Patch Set 1 #

Total comments: 3

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 3 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
qinmin
PTAL
6 years, 3 months ago (2014-09-18 18:05:47 UTC) #2
DaleCurtis
https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode779 content/renderer/media/android/webmediaplayer_android.cc:779: player_manager_->Start(player_id_); Isn't the player already started?
6 years, 3 months ago (2014-09-18 18:15:33 UTC) #3
qinmin
https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode779 content/renderer/media/android/webmediaplayer_android.cc:779: player_manager_->Start(player_id_); On 2014/09/18 18:15:33, DaleCurtis wrote: > Isn't the ...
6 years, 3 months ago (2014-09-18 18:21:21 UTC) #4
DaleCurtis
https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode779 content/renderer/media/android/webmediaplayer_android.cc:779: player_manager_->Start(player_id_); On 2014/09/18 18:21:21, qinmin wrote: > On 2014/09/18 ...
6 years, 3 months ago (2014-09-18 18:23:33 UTC) #5
qinmin
On 2014/09/18 18:23:33, DaleCurtis wrote: > https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc > File content/renderer/media/android/webmediaplayer_android.cc (right): > > https://codereview.chromium.org/580093005/diff/1/content/renderer/media/android/webmediaplayer_android.cc#newcode779 > ...
6 years, 3 months ago (2014-09-18 18:25:33 UTC) #6
DaleCurtis
lgtm
6 years, 3 months ago (2014-09-18 18:32:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580093005/1
6 years, 3 months ago (2014-09-18 19:44:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57832) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/16382) ios_rel_device ...
6 years, 3 months ago (2014-09-18 19:47:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/580093005/20001
6 years, 3 months ago (2014-09-18 21:35:31 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2314bc55e0c58e3a83e223fdc4aaeae388b57593
6 years, 3 months ago (2014-09-18 22:44:18 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 22:44:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f328dba01c4ed670a0e4a3d222545c52561a5dd
Cr-Commit-Position: refs/heads/master@{#295585}

Powered by Google App Engine
This is Rietveld 408576698