Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/notifications/extension_welcome_notification_unittest.cc

Issue 580093003: Factor Google Now welcome notifications out of DesktopNotificationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/extension_welcome_notification_unittest.cc
diff --git a/chrome/browser/notifications/extension_welcome_notification_unittest.cc b/chrome/browser/notifications/extension_welcome_notification_unittest.cc
index 6e037ad5b94118c6cf6d09e727513718fdc75232..8dcde90a524cd50cba5e5afacbc97b211ef2b969 100644
--- a/chrome/browser/notifications/extension_welcome_notification_unittest.cc
+++ b/chrome/browser/notifications/extension_welcome_notification_unittest.cc
@@ -23,8 +23,6 @@
#include "ui/message_center/fake_message_center.h"
#include "ui/message_center/notification.h"
-const char kChromeNowExtensionID[] = "pafkbggdmjlpgkdkcbjmhmfcdpncadgh";
-
class MockMessageCenter : public message_center::FakeMessageCenter {
public:
MockMessageCenter()
@@ -140,8 +138,8 @@ class ExtensionWelcomeNotificationTest : public testing::Test {
new base::ThreadTaskRunnerHandle(task_runner_));
profile_.reset(new TestingProfile());
delegate_ = new WelcomeNotificationDelegate();
- welcome_notification_ = ExtensionWelcomeNotification::Create(
- kChromeNowExtensionID, profile_.get(), delegate_);
+ welcome_notification_.reset(
+ ExtensionWelcomeNotification::Create(profile_.get(), delegate_));
}
virtual void TearDown() {
@@ -166,8 +164,9 @@ class ExtensionWelcomeNotificationTest : public testing::Test {
void ShowChromeNowNotification() const {
ShowNotification(
"ChromeNowNotification",
- message_center::NotifierId(message_center::NotifierId::APPLICATION,
- kChromeNowExtensionID));
+ message_center::NotifierId(
+ message_center::NotifierId::APPLICATION,
+ ExtensionWelcomeNotification::kChromeNowExtensionID));
}
void ShowRegularNotification() const {

Powered by Google App Engine
This is Rietveld 408576698