chrome/chrome_browser.gypi - Issue 580093003: Factor Google Now welcome notifications out of DesktopNotificationService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser.gypi

Issue 580093003: Factor Google Now welcome notifications out of DesktopNotificationService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser.gypi

diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi

index 3cf826c1b1799f87e98705d42d356fd741755222..b061b9f2f25c8201d7b24989bb82230d18e1e095 100644

--- a/chrome/chrome_browser.gypi

+++ b/chrome/chrome_browser.gypi

@@ -1751,10 +1751,6 @@

'browser/notifications/desktop_notification_service.h',

'browser/notifications/desktop_notification_service_factory.cc',

'browser/notifications/desktop_notification_service_factory.h',

- 'browser/notifications/extension_welcome_notification.cc',

- 'browser/notifications/extension_welcome_notification.h',

- 'browser/notifications/google_now_notification_stats_collector.cc',

- 'browser/notifications/google_now_notification_stats_collector.h',

'browser/notifications/message_center_notification_manager_win.cc',

'browser/notifications/notification.cc',

'browser/notifications/notification.h',

@@ -1776,6 +1772,12 @@

# Used on non-Android platforms when notifications are enabled.

'chrome_browser_non_android_notifications_sources': [

+ 'browser/notifications/extensions/extension_welcome_notification.cc',

+ 'browser/notifications/extensions/extension_welcome_notification.h',

+ 'browser/notifications/extensions/extension_welcome_notification_factory.cc',

+ 'browser/notifications/extensions/extension_welcome_notification_factory.h',

+ 'browser/notifications/extensions/google_now_notification_stats_collector.cc',

+ 'browser/notifications/extensions/google_now_notification_stats_collector.h',

'browser/notifications/message_center_notification_manager.cc',

'browser/notifications/message_center_notification_manager.h',

'browser/notifications/message_center_settings_controller.cc',

« chrome/browser/prefs/browser_prefs.cc ('K') | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »