use surface in SkView/SampleApp

use surface in SkView/SampleApp

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0397e9f3415b4646797f1b17e9a38b5deb864ff0

[reed1, 2014-09-18 13:32:27]

reed@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[reed1, 2014-09-18 13:32:30]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-09-18 13:33:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/580073003/1

[commit-bot: I haz the power, 2014-09-18 13:33:12]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from a valid reviewer till 2014-09-18 19:33 UTC

[robertphillips, 2014-09-18 14:52:08]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2014-09-18 14:52:21]

lgtm + nits & a question

https://codereview.chromium.org/580073003/diff/1/include/views/SkWindow.h
File include/views/SkWindow.h (right):

https://codereview.chromium.org/580073003/diff/1/include/views/SkWindow.h#new...
include/views/SkWindow.h:23: 
rm SkCanvas ?

https://codereview.chromium.org/580073003/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/580073003/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:273: 
SK_OVERRIDE ?

https://codereview.chromium.org/580073003/diff/1/src/views/SkWindow.cpp
File src/views/SkWindow.cpp (right):

https://codereview.chromium.org/580073003/diff/1/src/views/SkWindow.cpp#newco...
src/views/SkWindow.cpp:35: SkSurface* SkWindow::createSurface() {
It seems odd that this is a "const SkBitmap&"

[reed1, 2014-09-18 18:08:12]

https://codereview.chromium.org/580073003/diff/1/include/views/SkWindow.h
File include/views/SkWindow.h (right):

https://codereview.chromium.org/580073003/diff/1/include/views/SkWindow.h#new...
include/views/SkWindow.h:23: 
On 2014/09/18 14:52:20, robertphillips wrote:
> rm SkCanvas ?

Done.

https://codereview.chromium.org/580073003/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/580073003/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:273: 
On 2014/09/18 14:52:21, robertphillips wrote:
> SK_OVERRIDE ?

Done.

https://codereview.chromium.org/580073003/diff/1/src/views/SkWindow.cpp
File src/views/SkWindow.cpp (right):

https://codereview.chromium.org/580073003/diff/1/src/views/SkWindow.cpp#newco...
src/views/SkWindow.cpp:35: SkSurface* SkWindow::createSurface() {
On 2014/09/18 14:52:21, robertphillips wrote:
> It seems odd that this is a "const SkBitmap&"

ack.

[reed1, 2014-09-18 18:10:37]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-09-18 18:11:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/580073003/20001

[commit-bot: I haz the power, 2014-09-18 18:29:04]

Committed patchset #2 (id:20001) as 0397e9f3415b4646797f1b17e9a38b5deb864ff0

[Noel Gordon, 2014-10-11 12:44:30]

https://sites.google.com/site/skiadocs/user-documentation/samples-and-tutoria...

Step 2: Build the included HelloSkia Example

  Example app for windows no longer builds after this change.
  out/gyp/SkiaExamples.vcproj

[tfarina, 2014-10-11 12:59:51]

On 2014/10/11 12:44:30, Noel Gordon wrote:
>
https://sites.google.com/site/skiadocs/user-documentation/samples-and-tutoria...
> 
> Step 2: Build the included HelloSkia Example
> 
>   Example app for windows no longer builds after this change.
>   out/gyp/SkiaExamples.vcproj

Could you file a bug with the buikd error?