Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: chrome/browser/android/download/download_overwrite_infobar_delegate.h

Issue 580043002: [Android] Prompt with infobar on filename conflict (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: used Java DownloadInfo and fixed nits Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/download/download_overwrite_infobar_delegate.h
diff --git a/chrome/browser/android/download/download_overwrite_infobar_delegate.h b/chrome/browser/android/download/download_overwrite_infobar_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..53533372e74f26561d3afb4b0d86634da5386fae
--- /dev/null
+++ b/chrome/browser/android/download/download_overwrite_infobar_delegate.h
@@ -0,0 +1,54 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFOBAR_DELEGATE_H_
+
+#include "base/android/scoped_java_ref.h"
+#include "base/callback.h"
+#include "base/files/file_path.h"
+#include "chrome/browser/download/download_target_determiner_delegate.h"
+#include "components/infobars/core/infobar_delegate.h"
+
+using base::android::ScopedJavaGlobalRef;
Peter Kasting 2015/03/02 21:05:15 This shouldn't be here (nor the #include it refere
Changwan Ryu 2015/03/04 05:15:03 Done.
+
+class InfoBarService;
+
+namespace chrome {
+namespace android {
+
+// An infobar that asks if it is ok to overwrite an
+// existing file. Due to limited disk space on Android, two options are
+// presented to the user when downloading a file whose name conflicts with an
+// already present file:
+//
+// 1. Overwrite the file.
+// 2. Create a new file.
+//
+// Also, the user can dismiss the infobar to abort the download.
+//
+// Note that this infobar does not expire if the user subsequently navigates,
+// since such navigations won't automatically cancel the underlying download.
+class DownloadOverwriteInfoBarDelegate : public infobars::InfoBarDelegate {
+ public:
+ // This is called when the user chooses to overwrite the existing file.
+ virtual void OverwriteExistingFile() = 0;
+
+ // This is called when the user chooses to create a new file.
+ virtual void CreateNewFile() = 0;
+
+ // Get the file name to be downloaded.
Peter Kasting 2015/03/02 21:05:15 Nit: "Gets", not "Get" (several places)
Changwan Ryu 2015/03/04 05:15:03 Done.
+ virtual std::string GetFileName() const = 0;
+ // Get the download directory name.
+ virtual std::string GetDirName() const = 0;
+ // Get the full directory path.
+ virtual std::string GetDirFullPath() const = 0;
+
+ bool ShouldExpire(const NavigationDetails& details) const override;
+};
+
+} // namespace android
+} // namespace chrome
+
+#endif // CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFOBAR_DELEGATE_H_

Powered by Google App Engine
This is Rietveld 408576698