chrome/browser/download/download_target_determiner.cc - Issue 580043002: [Android] Prompt with infobar on filename conflict

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_target_determiner.cc

Issue 580043002: [Android] Prompt with infobar on filename conflict (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed ted's comments and added dismiss listener Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_target_determiner.cc

diff --git a/chrome/browser/download/download_target_determiner.cc b/chrome/browser/download/download_target_determiner.cc

index c0f44b69812d5b0e3b7071e423fd57a8084fcb36..b2a0c437ace93130ee0fd085dce4b09736b28f37 100644

--- a/chrome/browser/download/download_target_determiner.cc

+++ b/chrome/browser/download/download_target_determiner.cc

@@ -210,7 +210,11 @@ DownloadTargetDeterminer::Result

target_directory = download_prefs_->DownloadPath();

}

virtual_path_ = target_directory.Append(generated_filename);

+#if defined(OS_ANDROID)

+ conflict_action_ = DownloadPathReservationTracker::PROMPT;

+#else

conflict_action_ = DownloadPathReservationTracker::UNIQUIFY;

+#endif

should_notify_extensions_ = true;

} else {

virtual_path_ = download_->GetForcedFilePath();