[Android] Prompt with infobar on filename conflict

chrome/browser/ui/android/infobars/download_overwrite_infobar.cc

Index: chrome/browser/ui/android/infobars/download_overwrite_infobar.cc
diff --git a/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc b/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8ac5499e3b3e11c394f7de42e9f2a98f9a01b1b4
--- /dev/null
+++ b/chrome/browser/ui/android/infobars/download_overwrite_infobar.cc
@@ -0,0 +1,70 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/android/infobars/download_overwrite_infobar.h"
+
+#include "base/android/jni_android.h"
+#include "base/android/jni_array.h"
+#include "base/android/jni_string.h"
+#include "base/android/jni_weak_ref.h"
+#include "base/files/file_path.h"
+#include "chrome/browser/android/download/download_overwrite_infobar_delegate.h"
+#include "jni/DownloadOverwriteInfoBarDelegate_jni.h"
+
+using chrome::android::DownloadOverwriteInfoBarDelegate;
+
+// static
+scoped_ptr<infobars::InfoBar> DownloadOverwriteInfoBar::CreateInfoBar(
+    scoped_ptr<DownloadOverwriteInfoBarDelegate> delegate) {
+  return make_scoped_ptr(new DownloadOverwriteInfoBar(delegate.Pass()));
+}
+
+DownloadOverwriteInfoBar::~DownloadOverwriteInfoBar() {
+}
+
+DownloadOverwriteInfoBar::DownloadOverwriteInfoBar(
+    scoped_ptr<DownloadOverwriteInfoBarDelegate> delegate)
+    : InfoBarAndroid(delegate.Pass()), java_delegate_() {
+}
+
+ScopedJavaLocalRef<jobject> DownloadOverwriteInfoBar::CreateRenderInfoBar(
+    JNIEnv* env) {
+  java_delegate_.Reset(Java_DownloadOverwriteInfoBarDelegate_create(env));

[Ted C, 2015/02/26 00:57:56]

I find it quite odd that the infobar creates the java delegate instead of the
C++ delegate doing it.

Looking at AppBannerInfoBarDelegate, it creates and owns the java delegate
itself, which I think is closer to the model we want to follow.

[Changwan Ryu, 2015/03/02 14:46:37]

Done.

+  DownloadOverwriteInfoBarDelegate* delegate = GetDelegate();
+  ScopedJavaLocalRef<jstring> j_file_name =
+      base::android::ConvertUTF8ToJavaString(env, delegate->GetFileName());
+  ScopedJavaLocalRef<jstring> j_dir_name =
+      base::android::ConvertUTF8ToJavaString(env, delegate->GetDirName());
+  ScopedJavaLocalRef<jstring> j_dir_full_path =
+      base::android::ConvertUTF8ToJavaString(env, delegate->GetDirFullPath());
+  return Java_DownloadOverwriteInfoBarDelegate_showDownloadOverwriteInfoBar(
+      env, java_delegate_.obj(), reinterpret_cast<intptr_t>(this),
+      j_file_name.obj(), j_dir_name.obj(), j_dir_full_path.obj());
+}
+
+void DownloadOverwriteInfoBar::ProcessButton(int action,
+                                             const std::string& action_value) {
+  if (!owner())
+    return;  // We're closing; don't call anything, it might access the owner.
+
+  DownloadOverwriteInfoBarDelegate* delegate = GetDelegate();
+  if (action == InfoBarAndroid::ACTION_OVERWRITE)
+    delegate->OverwriteExistingFile();
+  else if (action == InfoBarAndroid::ACTION_CREATE_NEW_FILE)
+    delegate->CreateNewFile();
+  else
+    DCHECK(false);
+
+  RemoveSelf();
+}
+
+DownloadOverwriteInfoBarDelegate* DownloadOverwriteInfoBar::GetDelegate() {
+  return static_cast<DownloadOverwriteInfoBarDelegate*>(delegate());
+}
+
+// Native JNI methods ---------------------------------------------------------
+
+bool RegisterDownloadOverwriteInfoBarDelegate(JNIEnv* env) {
+  return RegisterNativesImpl(env);
+}