[Android] Prompt with infobar on filename conflict

chrome/browser/android/download/download_overwrite_info.h

Index: chrome/browser/android/download/download_overwrite_info.h
diff --git a/chrome/browser/android/download/download_overwrite_info.h b/chrome/browser/android/download/download_overwrite_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..19be3129e54ceb560c4268b66eeb1d8bc92dbde8
--- /dev/null
+++ b/chrome/browser/android/download/download_overwrite_info.h
@@ -0,0 +1,53 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.

[Ted C, 2015/02/26 00:57:56]

no need (c) here or anywhere else.

[Changwan Ryu, 2015/03/02 14:46:36]

Removed

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFO_H_
+#define CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFO_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+
+namespace chrome {
+namespace android {
+
+// Used to store all the information about overwriting behavior for an Android
+// download.
+struct DownloadOverwriteInfo {
+  DownloadOverwriteInfo(std::string file_name,

[Peter Kasting, 2015/02/25 06:24:57]

const &s?

Can we store a FilePath instead of the (file_name, dir_name, dir_full_path)
triple?  And a GURL for the URL?

[Changwan Ryu, 2015/03/02 14:46:36]

For the other code path that uses AndroidDownloadManager on the Java side, I
think it's better to keep it as is.
Removed URL by passing Java downloadinfo directly.

+                        std::string dir_name,
+                        std::string dir_full_path,
+                        std::string url,
+                        std::string content_disposition,
+                        std::string user_agent,
+                        std::string cookie,
+                        std::string referer,
+                        bool has_user_gesture,
+                        std::string mime_type,
+                        int64 content_length,
+                        bool is_GET_request);

[Peter Kasting, 2015/02/25 06:24:57]

Nit: Don't capitalize GET here (or elsewhere)

[Changwan Ryu, 2015/03/02 14:46:36]

Removed by passing Java DownloadInfo directly.

+  ~DownloadOverwriteInfo();
+
+  std::string file_name;
+  std::string dir_name;
+  std::string dir_full_path;
+  std::string url;
+  std::string content_disposition;
+  std::string user_agent;
+  std::string cookie;
+  std::string referer;
+  bool has_user_gesture;
+  std::string mime_type;
+  int64 content_length;
+  bool is_GET_request;
+  bool overwrite;
+  bool dismissed;
+
+  // Default copy constructor is used for passing this struct by value.

[Peter Kasting, 2015/02/25 06:24:57]

Nit: No need for this comment, allowing copies of data-only structs is standard
in Google style

[Changwan Ryu, 2015/03/02 14:46:36]

Class removed.

+};
+
+}  // namespace android
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFO_H_