[Android] Prompt with infobar on filename conflict

chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
index d03d98fb8ab7aff8fb84a599da3c6782847c23bc..9b182d3496b9acad17eae3740dff728447b3f113 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java
@@ -22,6 +22,7 @@ import org.chromium.base.VisibleForTesting;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.Tab;
 import org.chromium.chrome.browser.infobar.ConfirmInfoBar;
+import org.chromium.chrome.browser.infobar.DownloadOverwriteInfoBar;
 import org.chromium.chrome.browser.infobar.InfoBar;
 import org.chromium.chrome.browser.infobar.InfoBarListeners;
 import org.chromium.chrome.browser.tabmodel.TabModelSelector;
@@ -306,12 +307,56 @@ public class ChromeDownloadDelegate
         confirmDangerousDownload(downloadInfo);
     }
 
+    private boolean launchInfoBarIfFileExists(final DownloadInfo info) {

[qinmin, 2015/02/20 01:00:40]

java doc

[Changwan Ryu, 2015/02/23 06:50:37]

Done.

+        String fileName = info.getFileName();
+        File dir = Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_DOWNLOADS);
+        if (!dir.mkdir() && !dir.isDirectory()) return false;
+        String dirName = dir.getName();
+        final File file = new File(dir, info.getFileName());
+        String fullDirPath = file.getParent();
+        if (!file.exists()) return false;
+        if (TextUtils.isEmpty(fileName) || TextUtils.isEmpty(dirName)
+                || TextUtils.isEmpty(fullDirPath)) {
+            return false;
+        }
+
+        InfoBar infoBar = new DownloadOverwriteInfoBar(0, new DownloadOverwriteInfoBar.Callback() {

[Ted C, 2015/02/20 01:48:08]

We are really trying to avoid any java only infobar additions as we'd like to
slowly migrate to only a single path for infobars in the future.

Is there no way this can be converted to use a native delegate like the other
usage?

Maybe with more params when constructing the delegate?

[Changwan Ryu, 2015/02/23 06:50:37]

Hmm... I don't have a clear idea how this should be done, but it sounds like a
big change.

Basically, since we are allowing multiple infobars, we should keep track of Java
DownloadInfo objects or something similar in the ChromeDownloadDelegate so that
native callbacks can be correctly hooked up with Java side callbacks.

Then we need to make sure that we remove those objects when infobars are
dismissed.

Finally, native ChromeDownloadDelegate should be changed so that it can have the
same life cycle with the Java counterpart, and enable the native to call the
Java functions.

If you're ok, I'd like to leave it as a TODO and try it in a separate CL.

[Ted C, 2015/02/23 18:48:15]

Couldn't you just have a different native
DownloadOverwriteInfobarDelegate::Create method that takes a DownloadInfo
object?

You have access to the Tab->WebContents in this class so it should be relatively
easy to add another native infobar the same way you do it from
chrome_download_manager_delegate.cc.

I don't want this to be something that is "tried", I want it to be done.  So I
would need pretty strong convincing arguments why it is really had to pipe it
through the same code path.

+            @Override
+            public void onCloseButtonClicked(DownloadOverwriteInfoBar infoBar) {
+                infoBar.dismissJavaOnlyInfoBar();
+            }
+
+            @Override
+            public void onAction(DownloadOverwriteInfoBar infoBar, int action) {
+                if (action == InfoBar.ACTION_TYPE_OVERWRITE) {
+                    // Android DownloadManager does not have an overwriting option.
+                    // We remove the file here instead.
+                    file.delete();
+                }
+                if (action == InfoBar.ACTION_TYPE_OVERWRITE
+                        || action == InfoBar.ACTION_TYPE_CREATE_NEW_FILE) {
+                    enqueueDownloadManagerRequestInternal(info);
+                }
+                infoBar.dismissJavaOnlyInfoBar();
+            }
+        }, fileName, dirName, fullDirPath);
+        infoBar.setExpireOnNavigation(false);
+        mTab.getInfoBarContainer().addInfoBar(infoBar);
+        return true;
+    }
+
     /**
      * Sends the download request to Android download manager.
      *
      * @param info Download information about the download.
      */
     protected void enqueueDownloadManagerRequest(final DownloadInfo info) {
+        if (!launchInfoBarIfFileExists(info)) {
+            enqueueDownloadManagerRequestInternal(info);
+        }
+    }
+
+    private void enqueueDownloadManagerRequestInternal(final DownloadInfo info) {
         DownloadManagerService.getDownloadManagerService(
                 mContext.getApplicationContext()).enqueueDownloadManagerRequest(info, true);
         closeBlankTab();