chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java - Issue 580043002: [Android] Prompt with infobar on filename conflict

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

Issue 580043002: [Android] Prompt with infobar on filename conflict (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: also handles use cases from ChromeDownloadDelegate Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ChromeDownloadDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java » ('j') | chrome/browser/android/download_overwrite_infobar_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

index 71045581966e282facd0f27ef8825eea041bed64..0744ebe6ce97d2484c56a21f49211b092bd29d03 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java

@@ -655,8 +655,8 @@ public class DownloadManagerService extends BroadcastReceiver implements

@Override

protected void onPostExecute(Boolean result) {

- boolean isPendingOMADownload = mOMADownloadHandler.isPendingOMADownload(

- (long) mDownloadInfo.getDownloadId());

+ boolean isPendingOMADownload =

+ mOMADownloadHandler.isPendingOMADownload(mDownloadInfo.getDownloadId());

if (!result) {

Toast.makeText(mContext, mErrorId, Toast.LENGTH_SHORT).show();

if (isPendingOMADownload) {