Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5180)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/download/download_target_determiner.cc

Issue 580043002: [Android] Prompt with infobar on filename conflict (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed ted's comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/android/download_overwrite_infobar_delegate.cc ('K') | « chrome/browser/download/chrome_download_manager_delegate.cc ('k') | chrome/browser/ui/android/infobars/download_overwrite_infobar.h » ('j') | chrome/browser/ui/android/infobars/download_overwrite_infobar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_target_determiner.cc
diff --git a/chrome/browser/download/download_target_determiner.cc b/chrome/browser/download/download_target_determiner.cc
index c750432256bbb7d3c4f8be05537fb494fedc0eee..82fc9c3a29afe19a048eac4623c183c5c1096577 100644
--- a/chrome/browser/download/download_target_determiner.cc
+++ b/chrome/browser/download/download_target_determiner.cc
@@ -210,7 +210,11 @@ DownloadTargetDeterminer::Result
target_directory = download_prefs_->DownloadPath();
}
virtual_path_ = target_directory.Append(generated_filename);
+#if defined(OS_ANDROID)
+ conflict_action_ = DownloadPathReservationTracker::PROMPT;
+#else
conflict_action_ = DownloadPathReservationTracker::UNIQUIFY;
+#endif
should_notify_extensions_ = true;
} else {
virtual_path_ = download_->GetForcedFilePath();
« chrome/browser/android/download_overwrite_infobar_delegate.cc ('K') | « chrome/browser/download/chrome_download_manager_delegate.cc ('k') | chrome/browser/ui/android/infobars/download_overwrite_infobar.h » ('j') | chrome/browser/ui/android/infobars/download_overwrite_infobar.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698