[Android] Prompt with infobar on filename conflict

chrome/browser/android/download/download_overwrite_infobar_delegate_java_initiated.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFOBAR_DELEGATE_JAVA_INITIATED_H_
+#define CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFOBAR_DELEGATE_JAVA_INITIATED_H_
+
+#include "base/callback.h"
+#include "base/files/file_path.h"
+#include "chrome/browser/android/download/download_overwrite_info.h"
+#include "chrome/browser/android/download/download_overwrite_infobar_delegate.h"
+#include "components/infobars/core/infobar_delegate.h"
+
+class InfoBarService;
+
+namespace chrome {
+namespace android {
+
+// An infobar delegate that is initiated from Java side.
+class DownloadOverwriteInfoBarDelegateJavaInitiated

[Ted C, 2015/02/26 00:57:56]

The names of these two files is odd to me.  Is the real issue of whether it's
triggered from java vs native?  If so, I would argue as to why we have two code
paths to trigger this (or why we couldn't combine the logic entirely).

Or is the issue that one goes through the android download manager vs one that
goes through chrome download manager.  If so, I think we want the name to
reflect their usage instead of their origin of trigger.

[Changwan Ryu, 2015/03/02 14:46:36]

Done.

+    : public DownloadOverwriteInfoBarDelegate {
+ public:
+  ~DownloadOverwriteInfoBarDelegateJavaInitiated() override;
+
+  typedef base::Callback<void(const DownloadOverwriteInfo&)>

[Peter Kasting, 2015/02/25 06:24:57]

Typedefs go above members

[Changwan Ryu, 2015/03/02 14:46:36]

I see. Removed now since the callback use case is now gone.

+      FileSelectedFromDownloadOverwriteInfoCallback;

[Peter Kasting, 2015/02/25 06:24:57]

Nit: This name seems a bit verbose, can you shorten it?  What about e.g.
FileSelectedCallback?

[Changwan Ryu, 2015/03/02 14:46:36]

Ditto

+
+  static void Create(InfoBarService* infobar_service,
+                     const DownloadOverwriteInfo& info,
+                     const FileSelectedFromDownloadOverwriteInfoCallback&
+                         file_selected_callback);
+
+  void OverwriteExistingFile() override;

[Peter Kasting, 2015/02/25 06:24:57]

Nit: "// DownloadOverwriteInfoBarDelegate:"

How come these are public, while the overrides below are private?  Can they all
be private, assuming the caller accesses these functions polymorphically through
a pointer to the base class?

[Changwan Ryu, 2015/03/02 14:46:36]

Done.

+  void CreateNewFile() override;
+  std::string GetFileName() const override;
+  std::string GetDirName() const override;
+  std::string GetDirFullPath() const override;
+
+ private:
+  DownloadOverwriteInfoBarDelegateJavaInitiated(
+      const DownloadOverwriteInfo& info,
+      const FileSelectedFromDownloadOverwriteInfoCallback& callback);
+
+  // infobars::InfoBarDelegateForDownloadOverwriteInfo:

[Peter Kasting, 2015/02/25 06:24:57]

This is not a class name?  And if you meant to write
"infobars::InfoBarDelegate:", that also wouldn't be right, since you don't
directly inherit from that -- this should also be "//
DownloadOverwriteInfoBarDelegate:"

[Changwan Ryu, 2015/03/02 14:46:36]

Done.

+  bool ShouldExpire(const infobars::InfoBarDelegate::NavigationDetails& details)
+      const override;
+  void InfoBarDismissed() override;
+
+  DownloadOverwriteInfo download_overwrite_info_;
+
+  // A callback to notify that file selection is made (or cancelled).
+  FileSelectedFromDownloadOverwriteInfoCallback file_selected_callback_;
+
+  DISALLOW_COPY_AND_ASSIGN(DownloadOverwriteInfoBarDelegateJavaInitiated);
+};
+
+}  // namespace android
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_ANDROID_DOWNLOAD_DOWNLOAD_OVERWRITE_INFOBAR_DELEGATE_JAVA_INITIATED_H_